From: Eugene Surovegin <ebs@ebshome.net>
To: Stefan Roese <sr@denx.de>
Cc: Jean Delvare <khali@linux-fr.org>,
linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [PATCH 2/2] i2c: Add devtree-aware iic support for PPC4xx
Date: Mon, 15 Oct 2007 09:32:16 -0700 [thread overview]
Message-ID: <20071015163216.GA8127@gate.ebshome.net> (raw)
In-Reply-To: <200710151529.11485.sr@denx.de>
On Mon, Oct 15, 2007 at 03:29:11PM +0200, Stefan Roese wrote:
<snip>
> +#ifdef CONFIG_PPC_MERGE
> +static int device_idx = -1;
> +#endif
> +
<snip>
> + dev->idx = ++device_idx;
> + adap->nr = dev->idx;
Hmm, this doesn't look right. That mighty powerpc device everybody
was so excited about for the last years doesn't provide a device
instance number/index?
I think this approach is wrong, because I want i2c bus numbers for the
on-chip i2c to be fixed. This code makes it dependent on the order
devices were described in the device tree; how do you handle a
situation when only the second i2c adapter is connected? For OCP I
would just remove ocp_def for the IIC0.
--
Eugene
next prev parent reply other threads:[~2007-10-15 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 13:29 [PATCH 2/2] i2c: Add devtree-aware iic support for PPC4xx Stefan Roese
2007-10-15 16:32 ` Eugene Surovegin [this message]
2007-10-15 16:57 ` Grant Likely
2007-10-15 18:53 ` Scott Wood
2007-10-15 19:11 ` Eugene Surovegin
2007-10-15 19:16 ` Grant Likely
2007-10-15 19:18 ` Scott Wood
2007-10-15 19:13 ` Grant Likely
2007-10-15 19:24 ` Scott Wood
2007-10-15 19:48 ` Grant Likely
2007-10-15 19:54 ` Scott Wood
2007-10-15 20:26 ` Grant Likely
2007-10-15 20:45 ` Scott Wood
2007-10-16 3:20 ` David Gibson
2007-10-16 4:21 ` Grant Likely
2007-10-16 19:19 ` Jean Delvare
2007-10-17 0:37 ` David Gibson
2007-10-15 16:46 ` Grant Likely
2007-10-19 11:56 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015163216.GA8127@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.