All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Michael Buesch <mb@bu3sch.de>
Cc: Al Viro <viro@ftp.linux.org.uk>,
	gregkh@suse.de, David Brownell <dbrownell@users.sourceforge.net>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-kernel@vger.kernel.org
Subject: [patch] usb: fix ssb_ohci_probe() build bug
Date: Mon, 15 Oct 2007 19:43:21 +0200	[thread overview]
Message-ID: <20071015174321.GA27428@elte.hu> (raw)
In-Reply-To: <20071015173840.GA26109@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> find attached another config that reproduces the build failure above.
> 
> i think the reason is this:
> 
> CONFIG_SSB=m
> CONFIG_USB_OHCI_HCD=y
> CONFIG_USB_OHCI_HCD_SSB=y

the patch below fixes this for me.

	Ingo

----------------------->
Subject: usb: fix ssb_ohci_probe() build bug
From: Ingo Molnar <mingo@elte.hu>

fix ssb_ohci_probe() build bug:

 drivers/built-in.o: In function `ssb_ohci_probe':
 ohci-hcd.c:(.text+0xbff39): undefined reference to `ssb_device_enable'
 ohci-hcd.c:(.text+0xbff6f): undefined reference to `ssb_admatch_base'
 ohci-hcd.c:(.text+0xbff8b): undefined reference to `ssb_admatch_size'
 ohci-hcd.c:(.text+0xbffe5): undefined reference to `ssb_device_disable'
 [...]

the reason was that this Kconfig combination was allowed:

 CONFIG_SSB=m
 CONFIG_USB_OHCI_HCD=y
 CONFIG_USB_OHCI_HCD_SSB=y

the fix is to require a modular USB_OHCI_HCD build when SSB is modular.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/usb/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/usb/host/Kconfig
===================================================================
--- linux.orig/drivers/usb/host/Kconfig
+++ linux/drivers/usb/host/Kconfig
@@ -156,7 +156,7 @@ config USB_OHCI_HCD_PCI
 
 config USB_OHCI_HCD_SSB
 	bool "OHCI support for Broadcom SSB OHCI core"
-	depends on USB_OHCI_HCD && SSB && EXPERIMENTAL
+	depends on USB_OHCI_HCD && (SSB = y || SSB = CONFIG_USB_OHCI_HCD) && EXPERIMENTAL
 	default n
 	---help---
 	  Support for the Sonics Silicon Backplane (SSB) attached

  reply	other threads:[~2007-10-15 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14  3:29 [bug] usb build failure, latest -git Ingo Molnar
2007-10-14  3:35 ` Al Viro
2007-10-14  4:04   ` Ingo Molnar
2007-10-15 10:53   ` Ingo Molnar
2007-10-15 12:58     ` Michael Buesch
2007-10-15 13:50       ` [build bug] drivers/ssb " Ingo Molnar
2007-10-15 13:56         ` [patch] ssb: fix build failure Ingo Molnar
2007-10-15 17:38         ` [build bug] drivers/ssb build failure, latest -git Ingo Molnar
2007-10-15 17:43           ` Ingo Molnar [this message]
2007-10-15 18:08             ` [patch] usb: fix ssb_ohci_probe() build bug Michael Buesch
2007-10-24 19:46               ` Ingo Molnar
2007-10-24 20:21                 ` Greg KH
2007-10-14  3:40 ` [bug] usb build failure, latest -git Gabriel C
2007-10-14  9:32 ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071015174321.GA27428@elte.hu \
    --to=mingo@elte.hu \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.