Re: [PATCH 1/3] pluto/fc - Remove uses of the scsi_cmnd->done

[Matthew Wilcox <matthew@wil.cx>]

On Mon, Oct 15, 2007 at 07:25:14PM +0200, Boaz Harrosh wrote:
> From: Matthew Wilcox <matthew@wil.cx>
> 
> Remove uses of the scsi_cmnd ->done method from the fc4 driver.  It was
> being abused to flag commands that had already been through queuecommand;
> use the fcmd->proto value for that instead.  The fcmd->done pointer now
> becomes irrelevant.  Reuse the fcp_scsi_done name for an entirely different
> function which provides a handy single place to call ->scsi_done (removing
> some broken places that used to leak scsi_cmnds on error by calling ->done).

Looks right to me.  Thanks for picking this up.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."