From: Stephen Hemminger <shemminger@linux-foundation.org>
To: benh@kernel.crashing.org
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: netif_napi_add vs. multiple netdev's
Date: Tue, 16 Oct 2007 09:10:35 -0700 [thread overview]
Message-ID: <20071016091035.5fcd6d2e@freepuppy.rosehill> (raw)
In-Reply-To: <1192513633.19073.21.camel@pasglop>
On Tue, 16 Oct 2007 15:47:13 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> Hi Stehphen !
>
> The new netif_napi_add() function takes a netdev argument. In the EMAC
> case, there is one NAPI instance working on behalf of multiple netdev's,
> so that isn't very useful. For my EMAC patch (just posted to you & the
> list), I'm not passing NULL, but I'm wondering what would be a good way
> to handle netpoll here...
The problem is that netpoll only has a handle to the device being used
as a netconsole, but may need to activate the NAPI poll routine to
cleanup state. Perhaps teaching netpoll about N to 1 mappings would
be better.
>
> The way it's currently implemented, there's a list of NAPI's attached to
> the netdev, so obviously, that won't work for my usage scenario.
sky2 driver has potentially 2 ports for 1 NAPI instance.
> I'm not sure what's the best data structure that would be suitable for
> both N ndev's for 1 NAPI and 1 ndev for N NAPI's though... I could
> allocate "stub" list heads and queue those up, but that's a bit gross...
The new interface doesn't change anything. The old code had the
same problem vis-a-vis netpoll.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-10-16 16:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 5:47 netif_napi_add vs. multiple netdev's Benjamin Herrenschmidt
2007-10-16 16:10 ` Stephen Hemminger [this message]
2007-10-16 22:16 ` David Miller
2007-10-16 22:24 ` Benjamin Herrenschmidt
2007-10-16 23:37 ` Stephen Hemminger
2007-10-16 23:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016091035.5fcd6d2e@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.