All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: 1.0.15rc3 patch_analog.s bug + fix
Date: Tue, 16 Oct 2007 21:30:50 +0300	[thread overview]
Message-ID: <200710162130.51168.anarsoul@gmail.com> (raw)
In-Reply-To: <s5hmyuj47zf.wl%tiwai@suse.de>

> At Tue, 16 Oct 2007 10:39:55 +0300,
>
> Vasily Khoruzhick wrote:
> > [1  <text/plain; iso-8859-1 (quoted-printable)>]
> >
> > On Monday 15 October 2007 23:34:21 Peter Skensved wrote:
> > > > Hmm, the code logic looks correct to me.  If HP jack is present, the
> > > > internal speaker should be muted.  Otherwise it follows the state of
> > > > HP jack (muted/unmuted, that acts as a master switch)
> >
> > Code logic is broken.
> > Internal speakers muted while jack unplugged and unmuted while it's
> > plugged.
>
> No, it's the wrong logic.  The internal speaker should be unmuted when
> HP is unplugged, and muted when plugged.  You don't want to hear from
> both at the same time.
>

Sorry, i've made mistake, of course internal speakers should be muted when 
jack plugged. Patch that I've attached to previous message has exactly that 
logic.

> This implies rather that the jack detection itself is reversed from
> the standard.  Could you try the patch below?

Your patch works.

But it seems that there's another bug - i have loud click when i to play 
something or change mixer settings after not using audio for ~1min

Thanks.

Regards
Vasily
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2007-10-16 18:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-15  2:53 1.0.15rc3 patch_analog.s bug + fix Peter Skensved
2007-10-15 11:29 ` Takashi Iwai
2007-10-15 20:34   ` Peter Skensved
2007-10-16  7:39     ` Vasily Khoruzhick
2007-10-16 11:25       ` Takashi Iwai
2007-10-16 18:30         ` Vasily Khoruzhick [this message]
2007-10-17  7:34           ` Takashi Iwai
2007-10-17 16:10             ` Василий
2007-10-17 15:43               ` Takashi Iwai
2007-10-16  7:58     ` Vasily Khoruzhick
2007-10-16 11:32       ` Takashi Iwai
2007-10-16 12:14         ` Ma Begaj
2007-10-16 11:38     ` Takashi Iwai
2007-10-17 14:55       ` Peter Skensved

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710162130.51168.anarsoul@gmail.com \
    --to=anarsoul@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.