All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: shannon.nelson@intel.com, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, dan.j.williams@intel.com,
	randy.dunlap@oracle.com
Subject: Re: [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use
Date: Wed, 17 Oct 2007 17:47:56 -0700 (PDT)	[thread overview]
Message-ID: <20071017.174756.74746737.davem@davemloft.net> (raw)
In-Reply-To: <20071017174438.f0d6fe2e.akpm@linux-foundation.org>

From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 17 Oct 2007 17:44:38 -0700

> On Wed, 17 Oct 2007 17:14:39 -0700
> Shannon Nelson <shannon.nelson@intel.com> wrote:
> 
> > +	tx->callback = (void *)ioat_dma_test_callback;
> 
> and when I remove this cast I get
> 
> drivers/dma/ioat_dma.c: In function 'ioat_dma_self_test':
> drivers/dma/ioat_dma.c:718: warning: assignment from incompatible pointer type
> 
> because ioat_dma_test_callback isn't void-returning.  Something is wrong
> here.  I assume that ioat_dma_test_callback() should just be
> void-returning?

In fact this might crash on systems that conditionally pop
return values based upon whether the function is void or not.

  reply	other threads:[~2007-10-18  0:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18  0:14 [PATCH 1/5] I/OAT: cleanup pci issues Shannon Nelson
2007-10-18  0:14 ` [PATCH 2/5] I/OAT: clean up of dca provider start and stop Shannon Nelson
2007-10-18  0:14 ` [PATCH 3/5] I/OAT: clean up error handling and some print messages Shannon Nelson
2007-10-18  0:14 ` [PATCH 4/5] I/OAT: Tighten descriptor setup performance Shannon Nelson
2007-10-18  0:34   ` Andrew Morton
2007-10-18  0:41     ` Nelson, Shannon
2007-10-18  0:14 ` [PATCH 5/5] I/OAT: Add completion callback for async_tx interface use Shannon Nelson
2007-10-18  0:37   ` Andrew Morton
2007-10-18  0:46     ` Nelson, Shannon
2007-10-18  0:44   ` Andrew Morton
2007-10-18  0:47     ` David Miller [this message]
2007-10-18  0:53       ` Nelson, Shannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071017.174756.74746737.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=shannon.nelson@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.