From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: jeff@garzik.org, netdev@vger.kernel.org,
Emilian.Medve@Freescale.com, galak@gate.crashing.org,
leoli@Freescale.com, paulus@samba.org
Subject: Re: [patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes
Date: Wed, 17 Oct 2007 19:37:21 -0700 (PDT) [thread overview]
Message-ID: <20071017.193721.48531740.davem@davemloft.net> (raw)
In-Reply-To: <200710162124.l9GLOCTB017977@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Tue, 16 Oct 2007 14:24:12 -0700
> From: Andrew Morton <akpm@linux-foundation.org>
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Emil Medve <Emilian.Medve@Freescale.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Kumar Gala <galak@gate.crashing.org>
> Cc: Li Yang <leoli@freescale.com>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Please help my eyes, I can't see the fix:
> @@ -3454,7 +3454,7 @@ static int ucc_geth_rx(struct ucc_geth_p
> u16 length, howmany = 0;
> u32 bd_status;
> u8 *bdBuffer;
> - struct net_device * dev;
> + struct net_device *dev;
>
> ugeth_vdbg("%s: IN", __FUNCTION__);
>
This might be a coding style fix, as far as I can see, but I can't
imagine how it can effect compilation at all. It just removes a space
between the "*" and "dev" but that space is harmless.
next prev parent reply other threads:[~2007-10-18 2:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:24 [patch 4/4] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes akpm
2007-10-18 2:37 ` David Miller [this message]
2007-10-18 2:47 ` Andrew Morton
2007-10-18 2:50 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017.193721.48531740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Emilian.Medve@Freescale.com \
--cc=akpm@linux-foundation.org \
--cc=galak@gate.crashing.org \
--cc=jeff@garzik.org \
--cc=leoli@Freescale.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.