From: David Miller <davem@davemloft.net>
To: xemul@openvz.org
Cc: netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH] Consolidate creation of kmem caches with "calculated" names
Date: Wed, 17 Oct 2007 21:27:04 -0700 (PDT) [thread overview]
Message-ID: <20071017.212704.34759303.davem@davemloft.net> (raw)
In-Reply-To: <4716098A.9000201@openvz.org>
From: Pavel Emelyanov <xemul@openvz.org>
Date: Wed, 17 Oct 2007 17:09:30 +0400
> Some places in network (like protocol registration and dccp)
> generate the kmem cache name with snprintf() to create caches
> for several protocols with similar names.
>
> Make the routine that makes this in one place. Possibly, this
> is better to be put in mm/sl[uoa]b.c, but I haven't found
> any other places in kernel that require such functionality,
> so put this code (temporary?) in net/core/util.c
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
I don't think we should be putting kmem_*() interfaces in
a place like net/core/utils.c, please submit that seperately
to the SLAB and/or SLUB maintainers, and once that it in
we can add the uses to the networking.
Tanks.
prev parent reply other threads:[~2007-10-18 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 13:09 [PATCH] Consolidate creation of kmem caches with "calculated" names Pavel Emelyanov
2007-10-18 4:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017.212704.34759303.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.