From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ii4cj-0003L5-0S for mharc-grub-devel@gnu.org; Wed, 17 Oct 2007 04:51:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ii4ch-0003Kt-O0 for grub-devel@gnu.org; Wed, 17 Oct 2007 04:51:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ii4cf-0003Kd-Jm for grub-devel@gnu.org; Wed, 17 Oct 2007 04:51:26 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ii4cf-0003Ka-GA for grub-devel@gnu.org; Wed, 17 Oct 2007 04:51:25 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ii4cf-0002EE-0u for grub-devel@gnu.org; Wed, 17 Oct 2007 04:51:25 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Ii4cc-00065n-SP for grub-devel@gnu.org; Wed, 17 Oct 2007 10:51:23 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1Ii4c8-0004Yu-L4 for grub-devel@gnu.org; Wed, 17 Oct 2007 10:50:52 +0200 Date: Wed, 17 Oct 2007 10:50:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071017085052.GA17346@thorin> References: <20071016210907.GA10870@thorin> <87k5pmqgyr.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k5pmqgyr.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] split realmode and loader routines out of startup.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 08:51:27 -0000 On Wed, Oct 17, 2007 at 10:32:28AM +0200, Marco Gerards wrote: > > * kern/i386/pc/startup.S (grub_linux_prot_size): Moved to ... > > * kern/i386/loader.S (grub_linux_prot_size): ... here. > > I would say: > > (...): Moved from here... > (...): ... to here. > > Can you change that? Ok (ACKed also for the next patch I already sent). > > * kern/i386/pc/startup.S (grub_linux_tmp_addr): Moved to ... > > * kern/i386/loader.S (grub_linux_tmp_addr): ... here. > > * kern/i386/pc/startup.S (grub_linux_real_addr): Moved to ... > > * kern/i386/loader.S (grub_linux_real_addr): ... here. > > * kern/i386/pc/startup.S (grub_linux_boot_zimage): Moved to ... > > * kern/i386/loader.S (grub_linux_boot_zimage): ... here. > > * kern/i386/pc/startup.S (grub_linux_boot_bzimage): Moved to ... > > * kern/i386/loader.S (grub_linux_boot_bzimage): ... here. > > * kern/i386/pc/startup.S (grub_multiboot_real_boot): Moved to ... > > * kern/i386/loader.S (grub_multiboot_real_boot): ... here. > > * kern/i386/pc/startup.S (grub_multiboot2_real_boot): Moved to ... > > * kern/i386/loader.S (grub_multiboot2_real_boot): ... here. > > > > * kern/i386/realmode.S: New file. > > > > * kern/i386/pc/startup.S (protstack): Moved to ... > > * kern/i386/realmode.S (protstack): ... here. > > * kern/i386/pc/startup.S (gdt): Moved to ... > > * kern/i386/realmode.S (gdt): ... here. > > * kern/i386/pc/startup.S (prot_to_real): Moved to ... > > * kern/i386/realmode.S (prot_to_real): ... here. > > > > * kern/i386/pc/startup.S: Include `kern/i386/loader.S' and > > `kern/i386/realmode.S'. > > Why include? Can't it be linked? That's what a linker is for :-) Linking required wrapping a lot of references with EXT_C() macro, so I opted for #include (note this is done for lzo1x.S already). Also, #including stuff from the wrong [1] place caused cpu faults in my tests. With my current patch, code doesn't change much its location (real mode stuff at the beginning, loader stuff at the end). [1] Sorry, I'm not sure what wrong means here. Maybe it has to do with GAS syntax magic affecting cross-include borders or with a weird hardcoded reference to a specific memory layout. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)