From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ii66q-0003Bw-2H for mharc-grub-devel@gnu.org; Wed, 17 Oct 2007 06:26:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ii66o-0003Bc-QK for grub-devel@gnu.org; Wed, 17 Oct 2007 06:26:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ii66j-0003AD-Iu for grub-devel@gnu.org; Wed, 17 Oct 2007 06:26:37 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ii66j-0003A1-72 for grub-devel@gnu.org; Wed, 17 Oct 2007 06:26:33 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ii66i-0005e0-HI for grub-devel@gnu.org; Wed, 17 Oct 2007 06:26:32 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Ii66g-0006Xi-U4 for grub-devel@gnu.org; Wed, 17 Oct 2007 12:26:31 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1Ii66E-0005VF-SV for grub-devel@gnu.org; Wed, 17 Oct 2007 12:26:02 +0200 Date: Wed, 17 Oct 2007 12:26:02 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071017102602.GA21040@thorin> References: <20071016210907.GA10870@thorin> <87k5pmqgyr.fsf@xs4all.nl> <20071017085052.GA17346@thorin> <877ilmqcpt.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877ilmqcpt.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] split realmode and loader routines out of startup.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2007 10:26:39 -0000 On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote: > > > > Linking required wrapping a lot of references with EXT_C() macro, so I opted > > for #include (note this is done for lzo1x.S already). > > Is using EXT_C a problem? I don't know this code too well, > unfortunately :( No. Maybe linking bring in other problems, but EXT_C per se isn't a big deal. Though do we really want it? It doesn't seem to be a problem for lzo1x.S. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)