From: Al Viro <viro@ftp.linux.org.uk>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] fix not-and/or errors
Date: Wed, 17 Oct 2007 15:35:55 +0100 [thread overview]
Message-ID: <20071017143555.GI8181@ftp.linux.org.uk> (raw)
In-Reply-To: <47161451.9010309@tiscali.nl>
On Wed, Oct 17, 2007 at 03:55:29PM +0200, Roel Kluin wrote:
> if(!x & y) should either be if(!(x & y)) or if(!x && y)
> I made changes as seemed appropriate, but please review
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
> index 5cd3cad..7229319 100644
> --- a/arch/arm/mach-pxa/mfp.c
> +++ b/arch/arm/mach-pxa/mfp.c
> @@ -199,7 +199,7 @@ void pxa3xx_mfp_set_edge(int mfp, int edge)
>
> mfpr_val &= ~MFPR_EDGE_MASK;
> mfpr_val |= (edge & 0x3u) << MFPR_ERE_OFFSET;
> - mfpr_val |= (!edge & 0x1) << MFPR_EC_OFFSET;
> + mfpr_val |= (!(edge & 0x1)) << MFPR_EC_OFFSET;
>
> mfpr_writel(mfpr_off, mfpr_val);
> mfpr_sync();
ACK
> diff --git a/arch/sh/drivers/dma/dma-sh.c b/arch/sh/drivers/dma/dma-sh.c
> index 958bac1..e8f9c85 100644
> --- a/arch/sh/drivers/dma/dma-sh.c
> +++ b/arch/sh/drivers/dma/dma-sh.c
> @@ -89,7 +89,7 @@ static irqreturn_t dma_tei(int irq, void *dev_id)
>
> static int sh_dmac_request_dma(struct dma_channel *chan)
> {
> - if (unlikely(!chan->flags & DMA_TEI_CAPABLE))
> + if (unlikely(!(chan->flags & DMA_TEI_CAPABLE)))
> return 0;
>
> return request_irq(get_dmte_irq(chan->chan), dma_tei,
ACK
> --- a/drivers/acpi/asus_acpi.c
> +++ b/drivers/acpi/asus_acpi.c
> @@ -596,7 +596,7 @@ write_led(const char __user * buffer, unsigned long count,
> (led_out) ? (hotk->status | ledmask) : (hotk->status & ~ledmask);
>
> if (invert) /* invert target value */
> - led_out = !led_out & 0x1;
> + led_out = !(led_out & 0x1);
No, simply !led_out
> + if ((!battery->flags.battery_present_prev && acpi_battery_present(battery))
> + || (battery->flags.battery_present_prev && !acpi_battery_present(battery))) {
ITYM != and you've missed another one like that in the same file.
The rest is covered by earlier patches
next prev parent reply other threads:[~2007-10-17 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 13:46 [PATCH 1/4] fix not-and/or errors Roel Kluin
2007-10-17 13:49 ` [PATCH 2/4] " Roel Kluin
2007-10-17 13:54 ` Roel Kluin
2007-10-17 14:03 ` Peter Zijlstra
2007-10-17 13:53 ` [PATCH 3/4] " Roel Kluin
2007-10-17 13:55 ` [PATCH 4/4] " Roel Kluin
2007-10-17 14:05 ` Peter Zijlstra
2007-10-17 14:35 ` Al Viro [this message]
2007-10-18 14:02 ` [PATCH 4/4 returns] " Roel Kluin
2007-10-17 14:02 ` [PATCH 1/4] " Peter Zijlstra
2007-10-17 14:17 ` Andreas Schwab
2007-10-17 14:32 ` Al Viro
2007-10-18 14:38 ` Roel Kluin
2007-10-18 15:00 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017143555.GI8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.