All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: Please pull 'fixes-davem' branch of wireless-2.6
Date: Wed, 17 Oct 2007 10:53:15 -0400	[thread overview]
Message-ID: <20071017145315.GC5744@tuxdriver.com> (raw)
In-Reply-To: <200710162329.55966.flamingice@sourmilk.net>

On Tue, Oct 16, 2007 at 11:29:51PM -0400, Michael Wu wrote:
> On Tuesday 16 October 2007 22:31:46 John W. Linville wrote:
> > Bill Moss (1):
> >       mac80211: honor IW_SCAN_THIS_ESSID in siwscan ioctl
> >
> Where did this patch come from? The original patch looked nothing like this, 
> and this patch changes the behavior of siwscan incorrectly. If the interface 

"Nothing like this"?  I moved a conditional from inside a specific
case to outside the whole switch.  Let's not overstate things.

> is not STA, IBSS, or AP, scanning should not be permitted. This patch allows 
> scanning on any interface if a SSID is specified. NACK.

I refactored the patch in response to Johannes' email on 10/11 that
said "I think it should be done regardless of mode".

	http://marc.info/?l=linux-wireless&m=119209214914682&w=2

I seem to have botched the repost -- sorry about that.

Looking closer, it does seem like ieee80211_sta_req_scan may not be
robust enough to handle an inappropriate interface gracefully.  So,
let's add a patch that relocates the conditional after the switch,
and let the switch filter-out the bad interfaces for us.

Patch to follow (if I've figured-out git-send-email)...

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2007-10-17 15:11 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  2:31 Please pull 'fixes-davem' branch of wireless-2.6 John W. Linville
2007-10-17  3:29 ` Michael Wu
2007-10-17  3:29   ` Michael Wu
2007-10-17 14:53   ` John W. Linville [this message]
2007-10-17 14:54     ` [PATCH] mac80211: only honor IW_SCAN_THIS_ESSID in STA, IBSS, and AP modes John W. Linville
2007-10-18  4:16       ` David Miller
2007-10-18  4:16         ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2008-01-16 21:26 Please pull 'fixes-davem' branch of wireless-2.6 John W. Linville
2008-01-16 21:26 ` John W. Linville
2008-01-18 12:33 ` David Miller
2008-01-18 12:33   ` David Miller
2008-01-08  5:14 John W. Linville
2008-01-08  5:14 ` John W. Linville
2008-01-08  5:21 ` David Miller
2008-01-08  5:21   ` David Miller
2007-12-20 15:52 John W. Linville
2007-12-20 15:52 ` John W. Linville
2007-12-20 17:39 ` Chatre, Reinette
2007-12-20 18:51   ` Chatre, Reinette
2007-12-20 19:55     ` John W. Linville
2007-12-25  6:07 ` David Miller
2007-12-25  6:07   ` David Miller
2007-12-17 20:54 John W. Linville
2007-12-17 20:54 ` John W. Linville
2007-12-18  6:56 ` David Miller
2007-11-30  3:31 John W. Linville
2007-11-30 12:34 ` Herbert Xu
2007-11-20 22:10 John W. Linville
2007-11-20 22:10 ` John W. Linville
2007-11-21  1:25 ` David Miller
2007-11-21  1:25   ` David Miller
2007-11-15  2:51 John W. Linville
2007-11-15  2:51 ` John W. Linville
2007-11-15  3:40 ` David Miller
2007-11-07  0:13 John W. Linville
2007-11-07 14:38 ` Michael Buesch
2007-11-07 18:51 ` John W. Linville
2007-11-07 18:51   ` John W. Linville
2007-11-08  0:32   ` David Miller
2007-10-26  3:10 John W. Linville
2007-10-26  3:10 ` John W. Linville
2007-10-26  4:11 ` John W. Linville
2007-10-18 22:08 John W. Linville
2007-10-18 22:08 ` John W. Linville
2007-10-19  4:57 ` David Miller
2007-10-19  4:57   ` David Miller
2007-09-15 13:15 John W. Linville
2007-08-15  0:32 John W. Linville
2007-08-15  0:32 ` John W. Linville
2007-08-15  1:33 ` David Miller
2007-08-15  1:33   ` David Miller
2007-08-06 20:13 John W. Linville
2007-08-06 20:13 ` John W. Linville
2007-08-08  1:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071017145315.GC5744@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=flamingice@sourmilk.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.