From: Eric Wong <normalperson@yhbt.net>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: "Shawn O.Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH] Make the output of "git svn clone" less confusing.
Date: Thu, 18 Oct 2007 10:14:43 -0700 [thread overview]
Message-ID: <20071018171443.GA13040@untitled> (raw)
In-Reply-To: <87abqgiqsj.fsf@lysator.liu.se>
David Kågedal <davidk@lysator.liu.se> wrote:
> Eric Wong <normalperson@yhbt.net> writes:
>
> > "Shawn O. Pearce" <spearce@spearce.org> wrote:
> >> David Kågedal <davidk@lysator.liu.se> wrote:
> >> > The problem is that the first thing it prints is
> >> >
> >> > Initialized empty Git repository in .git/
> >> >
> >> > even if actually created a subdirectory and changed into it first. But to the
> >> > user, it looks like it is creating a .git/ dir in the directory he/she is
> >> > started git from.
> >>
> >> Eric, ack/nack?
> >
> > Nack, here's (hopefully) a better patch.
> >
> > David: agree/disagree?
>
> I don't really like this. Now you added a dependency on exactly how
> git-init-db will format its output. So if e.g. it is updated to use
> the absolute path your patch will create bogus output.
Yes, it's quite ugly :/ I think the best solution would be to fix all
GIT_DIR= setting issues and getting git-svn to always respect it for
init/clone/fetch (and tests, of course!). I probably won't get around
to doing any of this until Friday night or Saturday (PST), however...
Shawn: feel free to ignore this series for now
> Did you consider my suggestion of not doing the chdir befor running
> git-init-db?
That would likely break clone, and also this (from my message
under the commit message).
> I've actually just noticed that setting GIT_DIR= before running
> git-svn clone is very broken, and I probably won't get a chance
> to fix it for at least 24 hours (if I'm even awake)...
--
Eric Wong
prev parent reply other threads:[~2007-10-18 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 15:21 [PATCH] Make the output of "git svn clone" less confusing David Kågedal
2007-10-16 9:32 ` Eric Wong
2007-10-16 11:00 ` David Kågedal
2007-10-18 7:06 ` Shawn O. Pearce
2007-10-18 10:33 ` Eric Wong
[not found] ` <87abqgiqsj.fsf@lysator.liu.se>
2007-10-18 17:14 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018171443.GA13040@untitled \
--to=normalperson@yhbt.net \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.