From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@qumranet.com>
Cc: Andy Whitcroft <apw@shadowen.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: latest checkpatch
Date: Thu, 18 Oct 2007 22:51:47 +0200 [thread overview]
Message-ID: <20071018205147.GA1382@elte.hu> (raw)
In-Reply-To: <4717BBD0.7070504@qumranet.com>
* Avi Kivity <avi@qumranet.com> wrote:
> >> if (foo)
> >> bar();
> >> baz();
> >> one();
> >>
> >
> > detecting that would be awesome - it's often the sign of a real bug
> > because the intent is often to have bar() and baz() in the conditional
> > block.
>
> This is more useful operating on an entire file, so the script can see
> all the context.
there's "checkpatch --file" for complete files, so it can see the full
context if the user passes it in.
Ingo
next prev parent reply other threads:[~2007-10-18 20:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 19:26 [PATCH] checkpatch: Fix line number reporting Mike D. Day
2007-10-12 19:37 ` Andy Whitcroft
2007-10-13 18:35 ` Erez Zadok
2007-10-15 18:21 ` Andy Whitcroft
2007-10-16 17:59 ` Erez Zadok
2007-10-17 16:39 ` Andy Whitcroft
2007-10-18 11:13 ` latest checkpatch Ingo Molnar
2007-10-18 19:25 ` Andy Whitcroft
2007-10-18 19:39 ` Ingo Molnar
2007-10-18 20:02 ` Avi Kivity
2007-10-18 20:51 ` Ingo Molnar [this message]
2007-10-18 20:57 ` Jeff Garzik
2007-10-18 22:25 ` Randy Dunlap
2007-10-19 9:01 ` Andy Whitcroft
2007-10-18 23:16 ` Andi Kleen
2007-10-19 9:12 ` Ilpo Järvinen
2007-10-18 19:43 ` Andy Whitcroft
2007-10-18 20:00 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018205147.GA1382@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.