From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/4] aic7xxx: Add suspend/resume support
Date: Fri, 19 Oct 2007 14:02:46 +0100 [thread overview]
Message-ID: <20071019130246.GA30198@infradead.org> (raw)
In-Reply-To: <4718A497.1010106@suse.de>
On Fri, Oct 19, 2007 at 02:35:35PM +0200, Hannes Reinecke wrote:
> Christoph Hellwig wrote:
> > I think this needs a little restructuring. ahd_pci_suspend/ahd_pci_resume
> > should be merged into their callers and use the normal Linux pci accessors,
> > and ahd_suspend/ahd_resume are tiny enough to merged into the caller aswell.
> >
> Yes, partially. ahc_pci_resume() has to stay there as it uses quite some
> functions from aic7xxx_pci.c. And I'd rather keep the overall structure
> (ie split between linux-specific and generic pci access) for now.
> In the long run it should be restructured as we don't do cross-compilation
> with ***BSD anymore.
Ok..
> Ok. Done.
> Updated patch attached.
> More to your liking?
Much better. There's still some if ((rc = fo())) left, but it's probably
not worth to delay the patch further because of that. Just clean it up
in a followon patch.
next prev parent reply other threads:[~2007-10-19 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 8:32 [PATCH 1/4] aic7xxx: Add suspend/resume support Hannes Reinecke
2007-10-19 8:44 ` Christoph Hellwig
2007-10-19 12:35 ` Hannes Reinecke
2007-10-19 13:02 ` Christoph Hellwig [this message]
2007-10-19 13:45 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019130246.GA30198@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.