From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] ide/pci/sis5513.c: add missing "else"
Date: Fri, 19 Oct 2007 23:00:57 +0200 [thread overview]
Message-ID: <200710192300.58051.bzolnier@gmail.com> (raw)
In-Reply-To: <20071019140419.GC3778@stusta.de>
On Friday 19 October 2007, Adrian Bunk wrote:
> This patch adds a missing "else" that was missing in
> commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d.
>
> Spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
applied, thanks!
> ---
> 2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4
> diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
> index c1d280b..1680926 100644
> --- a/drivers/ide/pci/sis5513.c
> +++ b/drivers/ide/pci/sis5513.c
> @@ -264,7 +264,7 @@ static void sis_ata133_program_timings(ide_drive_t *drive, const u8 mode)
> if (mode >= XFER_MW_DMA_0) {
> t1 &= ~0x04; /* disable UDMA */
> idx = mode - XFER_MW_DMA_0 + 5;
> - }
> + } else
> idx = mode - XFER_PIO_0;
> t1 |= ini_time_value[clk][idx] << 12;
> t1 |= act_time_value[clk][idx] << 16;
prev parent reply other threads:[~2007-10-19 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 14:04 [2.6 patch] ide/pci/sis5513.c: add missing "else" Adrian Bunk
2007-10-19 21:00 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710192300.58051.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=bunk@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.