From: David Miller <davem@davemloft.net>
To: drzeus@drzeus.cx
Cc: netdev@vger.kernel.org
Subject: Re: net: alignment problem in icmp code
Date: Sat, 20 Oct 2007 22:12:57 -0700 (PDT) [thread overview]
Message-ID: <20071020.221257.78359286.davem@davemloft.net> (raw)
In-Reply-To: <20071020233540.43d2f103@poseidon.drzeus.cx>
From: Pierre Ossman <drzeus@drzeus.cx>
Date: Sat, 20 Oct 2007 23:35:40 +0200
> Structure assignment have to be aligned just like any assignment, and the skb could point to anything. So take the safe route and use a memcpy().
>
> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
Unfortunately this doesn't work, GCC can inline the memcpy just like
the assignment.
I tried to use a similar trick in the net/xfrm/xfrm_user.c code
but in the end it doesn't work at all.
next prev parent reply other threads:[~2007-10-21 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 21:35 net: alignment problem in icmp code Pierre Ossman
2007-10-21 5:12 ` David Miller [this message]
2007-10-21 9:34 ` Pierre Ossman
2007-10-21 19:48 ` David Miller
2007-10-21 21:21 ` Pierre Ossman
2007-10-21 23:02 ` David Miller
2007-10-22 4:54 ` Pierre Ossman
2007-10-22 5:15 ` David Miller
2007-10-22 7:23 ` Pierre Ossman
2007-10-22 8:31 ` David Miller
2007-10-22 8:42 ` Pierre Ossman
2007-10-22 9:05 ` David Miller
2007-10-22 9:26 ` Pierre Ossman
2007-10-22 9:52 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071020.221257.78359286.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drzeus@drzeus.cx \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.