From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IjZtU-0007An-Mp for mharc-grub-devel@gnu.org; Sun, 21 Oct 2007 08:27:00 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IjZtS-00078O-U3 for grub-devel@gnu.org; Sun, 21 Oct 2007 08:26:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IjZtP-000755-DA for grub-devel@gnu.org; Sun, 21 Oct 2007 08:26:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjZtO-00074X-6u for grub-devel@gnu.org; Sun, 21 Oct 2007 08:26:55 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IjZtN-0004d4-Tt for grub-devel@gnu.org; Sun, 21 Oct 2007 08:26:54 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IjZtK-0000Vq-Bw for grub-devel@gnu.org; Sun, 21 Oct 2007 14:26:52 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IjZt0-0000ld-E5 for grub-devel@gnu.org; Sun, 21 Oct 2007 14:26:30 +0200 Date: Sun, 21 Oct 2007 14:26:30 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071021122630.GA2868@thorin> References: <20071015143857.GA26571@thorin> <87wstnqhdb.fsf@xs4all.nl> <20071016183420.GA4335@thorin> <87odeyrj7r.fsf@xs4all.nl> <20071016200647.GA13827@thorin> <873awaqbci.fsf@xs4all.nl> <20071019123817.GA20469@thorin> <87ejforcoh.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ejforcoh.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Implement grub_sleep() and grub_ticksleep() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2007 12:26:59 -0000 Hi Marco, On Sun, Oct 21, 2007 at 12:21:02PM +0200, Marco Gerards wrote: > > diff -Nurp grub2/include/grub/misc.h grub2.time/include/grub/misc.h > > --- grub2/include/grub/misc.h 2007-07-22 01:32:22.000000000 +0200 > > +++ grub2.time/include/grub/misc.h 2007-10-19 14:19:53.000000000 +0200 > > @@ -83,6 +83,7 @@ grub_uint64_t EXPORT_FUNC(grub_divmod64) > > grub_uint32_t d, grub_uint32_t *r); > > > > /* Inline functions. */ > > + > > static inline unsigned int > > grub_abs (int x) > > You accidently added a whitespace above. > > Please remove this before you apply. It looks accidental, but it was intended. The whole code was changed from: /* Inline functions. */ grub_just_one_inline_function () { stuff; } to: /* Inline functions. */ grub_first_inline_function () { stuff; } /* Comments on the second function */ grub_second_inline_function () { stuff; } But if you still don't like that empty line, I have no objection on removing it of course :-) -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)