From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ijj5v-0001aU-IY
	for qemu-devel@nongnu.org; Sun, 21 Oct 2007 18:16:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ijj5t-0001aI-3i
	for qemu-devel@nongnu.org; Sun, 21 Oct 2007 18:16:26 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ijj5s-0001aF-Tj
	for qemu-devel@nongnu.org; Sun, 21 Oct 2007 18:16:24 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1Ijj5s-0003Lt-Jh
	for qemu-devel@nongnu.org; Sun, 21 Oct 2007 18:16:24 -0400
Date: Sun, 21 Oct 2007 23:16:11 +0100
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] qemu/hw piix_pci.c
Message-ID: <20071021221611.GK4544@networkno.de>
References: <E1IjL40-0006Um-G0@cvs.savannah.gnu.org>
	<471AFBDE.6080706@qumranet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <471AFBDE.6080706@qumranet.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@qumranet.com>
Cc: Igor Lvovsky <igor.lvovsky@qumranet.com>, qemu-devel@nongnu.org

Avi Kivity wrote:
>> Modified files:
>> 	hw             : piix_pci.c 
>> Log message:
>> 	Enable ACPI interrupts, by Igor Lvovsky.
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.11&r2=1.12
>>
>>   
>
> IMO this is a bug.  The patch enables the ACPI PCI interrupt every time it 
> is asserted.  If this is really needed, this implies that the guest OS 
> detects some sort of inconsistency and keeps turning the ACPI interrupt 
> off.
>
> The bug should be addressed instead of worked-around in this way.

Igor, could you clarify what happens there?


Thiemo