Re: [PATCH 01/01] arch/arm/plat-omap/mcbsp.c

[Tony Lindgren <tony@atomide.com>]

* Luís Cargnini <lvcargnini@gmail.com> [070925 20:26]:
> this patch modify the McBSP interrupt handling behavior turning the irq of
> McBSP ports shared and it is working, I'm deveolping a device driver and
> percepted that this is a change necessary for new device drivers could been
> implemented to tak advantage of McBSP and could use it, example is ADC
> communications throw McBSP interface for example, this modification do not
> harm the kernel and add more felxibility and functionality to the kernel.
> 
> -- linux-omap-2.6/arch/arm/plat-omap/mcbsp.c   2007-03-12
> 16:44:03.501890844-0300
> +++ linux-omap-2.6-instramed/arch/arm/plat-omap/mcbsp.c 2007-09-25 23:58:
> 39.324154145 -0300
> 
>  static irqreturn_t omap_mcbsp_tx_irq_handler(int irq, void *dev_id)
> @@ -304,7 +320,7 @@ int omap_mcbsp_request(unsigned int id)
> 
>         if (mcbsp[id].io_type == OMAP_MCBSP_IRQ_IO) {
>                 /* We need to get IRQs here */
> -               err = request_irq(mcbsp[id].tx_irq,
> omap_mcbsp_tx_irq_handler, 0,
> +               err = request_irq(mcbsp[id].tx_irq,
> omap_mcbsp_tx_irq_handler, IRQF_SHARED,
>                                   "McBSP",
>                                   (void *) (&mcbsp[id]));
>                 if (err != 0) {
> @@ -315,8 +331,7 @@ int omap_mcbsp_request(unsigned int id)
> 
>                 init_completion(&(mcbsp[id].tx_irq_completion));
> 
> -
> -               err = request_irq(mcbsp[id].rx_irq,
> omap_mcbsp_rx_irq_handler, 0,
> +               err = request_irq(mcbsp[id].rx_irq,
> omap_mcbsp_rx_irq_handler, IRQF_SHARED,
>                                   "McBSP",
>                                   (void *) (&mcbsp[id]));
>                 if (err != 0) {

Let's consider this once there's something else actually something using
the interrupt.

Tony