From: Alexey Dobriyan <adobriyan@sw.ru>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
devel@openvz.org
Subject: Re: [Devel] [PATCH 1/5] Cut off br_port fied from net_device
Date: Mon, 22 Oct 2007 16:49:15 +0400 [thread overview]
Message-ID: <20071022124915.GD6271@localhost.sw.ru> (raw)
In-Reply-To: <471C989D.9030207@openvz.org>
On Mon, Oct 22, 2007 at 04:33:33PM +0400, Pavel Emelyanov wrote:
> And add the forward declaration for br_handle_frame_hook in
> include/linux/if_bridge.h
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -699,8 +699,10 @@ struct net_device
> /* Network namespace this network device is inside */
> struct net *nd_net;
>
> +#if defined(CONFIG_BRIDGE) || defined(CONFIG_BRIDGE_MODULE)
> /* bridge stuff */
> struct net_bridge_port *br_port;
> +#endif
Such ifdefs are troublesome, because one can compile kernel with
CONFIG_BRIDGE=n and later decide he needs BRIDGE=m and go boom.
IPv6 -- the biggest violator of this rule should not be taken as
example. :^)
next prev parent reply other threads:[~2007-10-22 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 12:31 [PATCH 0/5] Diet struct net_device a bit Pavel Emelyanov
2007-10-22 12:33 ` [PATCH 1/5] Cut off br_port fied from net_device Pavel Emelyanov
2007-10-22 12:49 ` Alexey Dobriyan [this message]
2007-10-22 13:02 ` [Devel] " Pavel Emelyanov
2007-10-22 12:34 ` [PATCH 2/5] Cut off macvlan_port " Pavel Emelyanov
2007-10-22 12:35 ` [PATCH 3/5] Cut off ax25_ptr " Pavel Emelyanov
2007-10-22 12:36 ` [PATCH 4/5] Cut off ec_ptr " Pavel Emelyanov
2007-10-22 12:37 ` [PATCH 5/5] Cut off dn_ptr " Pavel Emelyanov
2007-10-23 17:07 ` [PATCH 0/5] Diet struct net_device a bit Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022124915.GD6271@localhost.sw.ru \
--to=adobriyan@sw.ru \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.