From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Arnon Gilboa <arnon.gilboa@qumranet.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support
Date: Mon, 22 Oct 2007 12:52:45 +0100 [thread overview]
Message-ID: <200710221252.47650.paul@codesourcery.com> (raw)
In-Reply-To: <64F9B87B6B770947A9F8391472E032160E323223@ehost011-8.exch011.intermedia.net>
On Monday 22 October 2007, Arnon Gilboa wrote:
> Hi,
>
> The attached patch adds isochronous transfers support to the OHCI
> emulation, similarly to the UHCI patch pushed two weeks ago.
> + uint16_t offset[8];
> +};
> +static inline int ohci_read_iso_td(uint32_t addr, struct ohci_iso_td *td)
> +{
> + return get_dwords(addr, (uint32_t *)td, sizeof(*td) >> 2);
> +}
This is wrong. It will break on big-endian hosts.
set_dwords only DTRT if all the structure fields are 32-bit.
Paul
next prev parent reply other threads:[~2007-10-22 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 10:19 [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support Arnon Gilboa
2007-10-22 10:29 ` Itamar Heim
2007-10-22 12:38 ` Hetz Ben Hamo
2007-10-22 12:41 ` Arnon Gilboa
2007-10-22 10:44 ` Dor Laor
2007-10-22 10:50 ` Arnon Gilboa
2007-10-22 11:29 ` Michal Schulz
2007-10-22 11:52 ` Paul Brook [this message]
2007-10-22 15:04 ` Arnon Gilboa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710221252.47650.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=arnon.gilboa@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.