From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ijvq3-0000LL-Ic
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 07:52:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ijvq2-0000KY-Vn
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 07:52:55 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ijvq2-0000KJ-RU
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 07:52:54 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Ijvq1-0005AG-V5
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 07:52:54 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support
Date: Mon, 22 Oct 2007 12:52:45 +0100
References: <64F9B87B6B770947A9F8391472E032160E323223@ehost011-8.exch011.intermedia.net>
In-Reply-To: <64F9B87B6B770947A9F8391472E032160E323223@ehost011-8.exch011.intermedia.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200710221252.47650.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Arnon Gilboa <arnon.gilboa@qumranet.com>

On Monday 22 October 2007, Arnon Gilboa wrote:
> Hi,
>
> The attached patch adds isochronous transfers support to the OHCI
> emulation, similarly to the UHCI patch pushed two weeks ago.

> +    uint16_t offset[8];
> +};

> +static inline int ohci_read_iso_td(uint32_t addr, struct ohci_iso_td *td)
> +{
> +    return get_dwords(addr, (uint32_t *)td, sizeof(*td) >> 2);
> +}

This is wrong. It will break on big-endian hosts.
set_dwords only DTRT if all the structure fields are 32-bit.

Paul