All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ursula Braun <braunu@de.ibm.com>
To: jgarzik@pobox.com, netdev@vger.kernel.org, linux-s390@vger.kernel.org
Cc: frank.blaschka@de.ibm.com, mschwid2@linux.vnet.ibm.com,
	heicars2@linux.vnet.ibm.com, apw@shadowen.org,
	kamalesh@linux.vnet.ibm.com, kaber@trash.net,
	shemminger@linux-foundation.org
Subject: [patch 1/2] : remove header_ops bug in qeth driver
Date: Mon, 22 Oct 2007 16:16:14 +0200	[thread overview]
Message-ID: <20071022142044.628766000@linux.vnet.ibm.com> (raw)
In-Reply-To: 20071022141613.957690000@linux.vnet.ibm.com

[-- Attachment #1: qeth.patch --]
[-- Type: text/plain, Size: 945 bytes --]

From: Ursula Braun <braunu@de.ibm.com>

Remove qeth bug caused by commit:
[NET]: Move hardware header operations out of netdevice.

This is the second part of the qeth header_ops patch, since
first patch sent 10/19 has been insufficient.
Nevertheless first patch is still valid and should be kept.

Signed-off-by: Ursula Braun <braunu@de.ibm.com>
---
 include/linux/netdevice.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-uschi/include/linux/netdevice.h
===================================================================
--- linux-2.6-uschi.orig/include/linux/netdevice.h
+++ linux-2.6-uschi/include/linux/netdevice.h
@@ -834,7 +834,7 @@ static inline int dev_hard_header(struct
 				  const void *daddr, const void *saddr,
 				  unsigned len)
 {
-	if (!dev->header_ops)
+	if (!dev->header_ops || !dev->header_ops->create)
 		return 0;
 
 	return dev->header_ops->create(skb, dev, type, daddr, saddr, len);

-- 

  reply	other threads:[~2007-10-22 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22 14:16 [patch 0/2] remove header_ops bug in qeth driver (part 2) Ursula Braun
2007-10-22 14:16 ` Ursula Braun [this message]
2007-10-24  0:23   ` [patch 1/2] : remove header_ops bug in qeth driver Jeff Garzik
2007-10-22 14:16 ` [patch 2/2] s390 MAINTAINERS Ursula Braun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071022142044.628766000@linux.vnet.ibm.com \
    --to=braunu@de.ibm.com \
    --cc=apw@shadowen.org \
    --cc=frank.blaschka@de.ibm.com \
    --cc=heicars2@linux.vnet.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=kaber@trash.net \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=mschwid2@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.