From: Matthew Garrett <mjg59@srcf.ucam.org>
To: John Belmonte <john@neggie.net>
Cc: Jonathan McDowell <noodles@earth.li>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add bluetooth support to toshiba-acpi driver
Date: Mon, 22 Oct 2007 15:54:16 +0100 [thread overview]
Message-ID: <20071022145415.GA4912@srcf.ucam.org> (raw)
In-Reply-To: <471C88E2.3020102@neggie.net>
On Mon, Oct 22, 2007 at 07:26:26AM -0400, John Belmonte wrote:
> The /proc/acpi/toshiba interface should not be expanded-- do not apply
> this patch. If any patch is applied, it would be to optionally
> implement the generic /dev/toshiba interface so that user space tools
> like toshset can operate.
The correct interface is rfkill, which will require this functionality
to be in-kernel anyway. I can see the argument against implementing it
in /proc/acpi/toshiba (further proc interface bloat), but not against
doing it in-kernel.
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2007-10-22 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 17:35 [PATCH] Add bluetooth support to toshiba-acpi driver Jonathan McDowell
2007-10-21 17:35 ` Jonathan McDowell
2007-10-22 2:30 ` Andrey Borzenkov
2007-10-22 8:11 ` Jonathan McDowell
2007-10-22 11:26 ` John Belmonte
2007-10-22 11:26 ` John Belmonte
2007-10-22 14:28 ` Jonathan McDowell
2007-10-22 14:54 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022145415.GA4912@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=john@neggie.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.