From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] startup.S does not find includes
Date: Mon, 22 Oct 2007 17:22:58 +0200 [thread overview]
Message-ID: <20071022152258.GA23548@thorin> (raw)
In-Reply-To: <ffi8lg$f3t$1@ger.gmane.org>
On Mon, Oct 22, 2007 at 06:31:22AM -0700, walt wrote:
> Christian Franke wrote:
> >Robert Millan wrote:
> >>On Sun, Oct 21, 2007 at 06:56:21PM +0200, Christian Franke wrote:
> >>>Hi,
> >>>
> >>>some recent checkin appearently introduces the following regression:
> >>>
> >>>Compilation fails if configure'd outside of $(srcdir).
> >>>#include "kern/i386/realmode.S" and "kern/i386/loader.S" fail in
> >>>startup.S.
> >>
> >>Uhm I just noticed that previously existing #includes have relative
> >>paths,
> >>e.g.:
> >>
> >>#include "lzo1x.S"
> >>
> >>Perhaps I should have done the same instead of adding new include dirs.
> >>
> >>Thoughts?
> >>
> >
> >For kern/i386/pc/startup.S:
> >
> >#include "../realmode.S" // include pc-independent i386 realmode code
> >
> >Should work without any -I option.
>
> I considered that, but wouldn't it break compilation when building
> in-tree, ie without an obj directory?
Why would it?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
next prev parent reply other threads:[~2007-10-22 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 16:56 [PATCH] startup.S does not find includes Christian Franke
2007-10-21 19:19 ` Robert Millan
2007-10-21 19:33 ` Christian Franke
2007-10-22 13:31 ` walt
2007-10-22 15:22 ` Robert Millan [this message]
2007-10-22 16:05 ` walt
2007-10-22 20:15 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022152258.GA23548@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.