From: Theodore Tso <tytso@mit.edu>
To: "Jose R. Santos" <jrs@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 10/14] Make e2fsck uninit block group aware.
Date: Mon, 22 Oct 2007 14:21:09 -0400 [thread overview]
Message-ID: <20071022182108.GB6619@thunk.org> (raw)
In-Reply-To: <20071022110202.57dc2984@rx8>
On Mon, Oct 22, 2007 at 11:02:02AM -0500, Jose R. Santos wrote:
> Hi Ted,
>
> Aneesh was nice enough to explain how to checkout the next branch.
> This is the only patch that broke so I'm attaching one that applies
> cleanly
Thanks, I was able to clean that up fairly easily myself. I noticed
though that after applying the patch series, "make check" blew up:
making check in lib/ext2fs
make[1]: Entering directory `/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs'
CC ../../../lib/ext2fs/tst_bitops.c
LD tst_bitops
CC ../../../lib/ext2fs/tst_badblocks.c
LD tst_badblocks
rw_bitmaps.o: In function `read_bitmaps':
/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs/../../../lib/ext2fs/rw_bitmaps.c:237: undefined reference to `ext2fs_group_desc_csum_verify'
/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs/../../../lib/ext2fs/rw_bitmaps.c:260: undefined reference to `ext2fs_group_desc_csum_verify'
collect2: ld returned 1 exit status
make[1]: *** [tst_badblocks] Error 1
make[1]: Leaving directory `/usr/projects/e2fsprogs/e2fsprogs/build/lib/ext2fs'
make: *** [check-recursive] Error 1
That's a relatively straightforward adjustment to lib/ext2fs/Makefile.in;
but please do make sure you run "make check" at the end of each patch series.
In fact, something I will normally try to do is make sure that "make
check" runs cleanly after every single patch in a patch series. That
makes it a lot easier to do git bisect runs.
Thanks,
- Ted
next prev parent reply other threads:[~2007-10-22 18:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 2:03 [PATCH 2 00/14][e2fsprogs] Uninit block group break down Jose R. Santos
2007-10-22 2:03 ` [PATCH 01/14] Reorder some of the $(SRCS) in alphabetical order Jose R. Santos
2007-10-22 2:03 ` [PATCH 02/14] Add initial checksum support Jose R. Santos
2007-10-22 2:03 ` [PATCH 03/14] Add uninit block group support on libe2fs Jose R. Santos
2007-10-22 2:03 ` [PATCH 04/14] Rename feature name from gdt_checksum to uninit_groups Jose R. Santos
2007-10-22 2:03 ` [PATCH 05/14] Add support for creating filesystems using uninit block group Jose R. Santos
2007-10-22 2:03 ` [PATCH 06/14] Make tune2fs uninit block group aware Jose R. Santos
2007-10-22 2:03 ` [PATCH 07/14] Make dumpe2fs " Jose R. Santos
2007-10-22 2:03 ` [PATCH 08/14] Make resize2fs " Jose R. Santos
2007-10-22 2:03 ` [PATCH 09/14] Make debugfs " Jose R. Santos
2007-10-22 2:04 ` [PATCH 10/14] Make e2fsck " Jose R. Santos
2007-10-22 16:02 ` Jose R. Santos
2007-10-22 18:21 ` Theodore Tso [this message]
2007-10-22 2:04 ` [PATCH 11/14] Update uninit block group documetation for some of the utilities Jose R. Santos
2007-10-22 2:04 ` [PATCH 12/14] Fix test cases Jose R. Santos
2007-10-22 2:04 ` [PATCH 13/14] Add new mm_lazy test case Jose R. Santos
2007-10-22 2:04 ` [PATCH 14/14] Add m_uninit " Jose R. Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022182108.GB6619@thunk.org \
--to=tytso@mit.edu \
--cc=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.