From: Robert Millan <rmh@aybabtu.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] flush stderr in grub_util_info
Date: Mon, 22 Oct 2007 22:05:56 +0200 [thread overview]
Message-ID: <20071022200556.GC31128@thorin> (raw)
In-Reply-To: <20071005105049.GA29900@thorin>
Committed.
On Fri, Oct 05, 2007 at 12:50:49PM +0200, Robert Millan wrote:
>
> I run into this when debugging a problem with grub-probe silently hanging
> when opening /dev/fd0. Turns out that because of stderr buffering I didn't
> get to see the output at all. I think grub_util_info should flush it since
> it can be critical information to find a problem (in my case, a bogus /dev/fd0
> entry in device.map).
>
> See attached patch.
>
> --
> Robert Millan
>
> <GPLv2> I know my rights; I want my phone call!
> <DRM> What use is a phone call, if you are unable to speak?
> (as seen on /.)
> 2007-10-05 Robert Millan <rmh@aybabtu.com>
>
> * util/misc.c (grub_util_info): flush stderr before returning.
>
> diff -ur grub2/util/misc.c grub2.probe/util/misc.c
> --- grub2/util/misc.c 2007-07-22 01:32:31.000000000 +0200
> +++ grub2.probe/util/misc.c 2007-10-05 12:46:14.000000000 +0200
> @@ -53,6 +53,7 @@
> vfprintf (stderr, fmt, ap);
> va_end (ap);
> fputc ('\n', stderr);
> + fflush (stderr);
> }
> }
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
prev parent reply other threads:[~2007-10-22 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 10:50 [PATCH] flush stderr in grub_util_info Robert Millan
2007-10-22 20:05 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022200556.GC31128@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.