Re: [PATCH 0/5] pvSCSI (SCSI pass through) driver

[Jun Kamada <kama@jp.fujitsu.com>]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Dear Keir-san,

On Mon, 22 Oct 2007 09:58:17 +0100
Keir Fraser <Keir.Fraser@cl.cam.ac.uk> wrote:
> What's the CONFIG_XEN_FC stuff all about? It doesn't appear to be
> configurable (so it's always off), it's ifdef'ed all over the place, and
> there are dead files (e.g., fcfront.c) that presumably would depend on that
> option.
> 
> Either it needs to be plumbed in properly, or the XEN_FC stuff needs to be
> stripped out entirely from this patchset.

The CONFIG_XEN_FC stuff is used for activating FC(Fibre Channel)
transport layer functionality. I will attach additional patch for the
stuff.


Please note:

The FC transport functionality for PV driver on HVM domain is not
activated even if this stuff is set. It is only available for 2.6.18
kernel for PV domain.
This is why definition of "struct fc_function_template" used for the
FC transport functionality are differrent for each kernel version.
Therefore "#ifdef" switch is needed for each kernel version. We didn't
implement the switch on current implementation.

Best regards,


-----
Jun Kamada

[-- Attachment #2: modify_Make_for_CONFIG_XEN_FC.patch --]
[-- Type: application/octet-stream, Size: 2394 bytes --]

# HG changeset patch
# User t.horikoshi@jp.fujitsu.com
# Date 1193114725 -32400
# Node ID 9ca42e496ee3555e0576fcabd75942dca8b3825f
# Parent  b8a4ef7c01aa345d820169266a6aa88c448f7aa5
[LINUX] modify Makefile for CONFIG_XEN_FC

Signed-off-by: Tomonari Horikoshi <t.horikoshi@jp.fujitsu.com>
Signed-off-by: Tsunehisa Doi <Doi.Tsunehisa@jp.fujitsu.com>
Signed-off-by: Jun Kamada <kama@jp.fujitsu.com>
Signed-off-by: Akira Hayakawa <hayakawa.akira@jp.fujitsu.com>

diff -r b8a4ef7c01aa -r 9ca42e496ee3 drivers/xen/Kconfig
--- a/drivers/xen/Kconfig	Fri Oct 19 08:59:03 2007 +0900
+++ b/drivers/xen/Kconfig	Tue Oct 23 13:45:25 2007 +0900
@@ -61,6 +61,21 @@ config XEN_SCSI_BACKEND
 	help
 	  The SCSI backend driver allows the kernel to export its SCSI HBAs
 	  to other guests via a high-performance shared-memory interface.
+
+choice
+	prompt "SCSI Backend Mode"
+	depends on XEN_SCSI_BACKEND
+	default XEN_SCSI_BACKEND_SCSI
+
+config XEN_SCSI_BACKEND_SCSI
+	bool "Not FC"
+
+config XEN_FC
+	bool "FC driver support"
+	---help---
+           The function of scsi_transport_fc is add.
+
+endchoice
 
 config XEN_BLKDEV_TAP
 	tristate "Block-device tap backend driver"
diff -r b8a4ef7c01aa -r 9ca42e496ee3 drivers/xen/scsiback/Makefile
--- a/drivers/xen/scsiback/Makefile	Fri Oct 19 08:59:03 2007 +0900
+++ b/drivers/xen/scsiback/Makefile	Tue Oct 23 13:45:25 2007 +0900
@@ -1,2 +1,8 @@ obj-$(CONFIG_XEN_SCSI_BACKEND)	+= xen-sc
-obj-$(CONFIG_XEN_SCSI_BACKEND)	+= xen-scsibk.o
-xen-scsibk-y			+= interface.o scsiback.o xenbus.o comback.o traceback.o
+ifeq ($(CONFIG_XEN_FC),y)
+  EXTRA_CFLAGS += -DCONFIG_XEN_FC
+  obj-$(CONFIG_XEN_SCSI_BACKEND)	+= xen-fcscsibk.o
+  xen-fcscsibk-y			+= interface.o scsiback.o xenbus.o fcback.o comback.o traceback.o
+else
+  obj-$(CONFIG_XEN_SCSI_BACKEND)	+= xen-scsibk.o
+  xen-scsibk-y				+= interface.o scsiback.o xenbus.o comback.o traceback.o
+endif
diff -r b8a4ef7c01aa -r 9ca42e496ee3 drivers/xen/scsifront/Makefile
--- a/drivers/xen/scsifront/Makefile	Fri Oct 19 08:59:03 2007 +0900
+++ b/drivers/xen/scsifront/Makefile	Tue Oct 23 13:45:25 2007 +0900
@@ -1,2 +1,8 @@
+ifeq ($(CONFIG_XEN_FC),y)
+  EXTRA_CFLAGS += -DCONFIG_XEN_FC
+  obj-$(CONFIG_XEN_SCSI_FRONTEND)	:= xenfcscsi.o
+  xenfcscsi-objs := scsifront.o fcfront.o comfront.o tracefront.o
+else
   obj-$(CONFIG_XEN_SCSI_FRONTEND)	:= xenscsi.o
   xenscsi-objs := scsifront.o comfront.o tracefront.o
+endif

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel