From: Scott Wood <scottwood@freescale.com>
To: Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com,
David Miller <davem@davemloft.net>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings
Date: Tue, 23 Oct 2007 12:10:05 -0500 [thread overview]
Message-ID: <20071023171005.GA4638@loki.buserror.net> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E2701685446@az33exm24.fsl.freescale.net>
On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote:
> Are you suggesting we leave those warnings there until somebody decides
> to fix all the portability issues of this driver? My patch is a small
> and insignificant improvement and not the revolution you're asking for,
> but is an small improvement today (I dislike warnings) vs. an improbable
> big one in the future.
It is not an improvement, as it moves the driver further away from being
64-bit clean. A better fix would be to change the definition of
tx/rx_bd_ring_offset to unsigned long (or better yet, a union).
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Medve Emilian-EMMEDVE1 <Emilian.Medve@freescale.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, jgarzik@pobox.com,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings
Date: Tue, 23 Oct 2007 12:10:05 -0500 [thread overview]
Message-ID: <20071023171005.GA4638@loki.buserror.net> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E2701685446@az33exm24.fsl.freescale.net>
On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote:
> Are you suggesting we leave those warnings there until somebody decides
> to fix all the portability issues of this driver? My patch is a small
> and insignificant improvement and not the revolution you're asking for,
> but is an small improvement today (I dislike warnings) vs. an improbable
> big one in the future.
It is not an improvement, as it moves the driver further away from being
64-bit clean. A better fix would be to change the definition of
tx/rx_bd_ring_offset to unsigned long (or better yet, a union).
-Scott
next prev parent reply other threads:[~2007-10-23 17:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 22:15 [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings Emil Medve
2007-10-18 22:15 ` Emil Medve
2007-10-19 0:30 ` David Miller
2007-10-19 0:30 ` David Miller
2007-10-19 13:39 ` Medve Emilian-EMMEDVE1
2007-10-19 13:39 ` Medve Emilian-EMMEDVE1
2007-10-19 23:41 ` David Miller
2007-10-19 23:41 ` David Miller
2007-10-22 13:47 ` Medve Emilian-EMMEDVE1
2007-10-22 13:47 ` Medve Emilian-EMMEDVE1
2007-10-23 3:38 ` Li Yang-r58472
2007-10-23 3:38 ` Li Yang-r58472
2007-10-23 17:10 ` Scott Wood [this message]
2007-10-23 17:10 ` Scott Wood
2007-10-19 14:35 ` Timur Tabi
2007-10-19 14:35 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023171005.GA4638@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=Emilian.Medve@freescale.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.