From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IkQDD-0005VP-Tq for mharc-grub-devel@gnu.org; Tue, 23 Oct 2007 16:18:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkQDB-0005UV-RW for grub-devel@gnu.org; Tue, 23 Oct 2007 16:18:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkQDA-0005Td-1D for grub-devel@gnu.org; Tue, 23 Oct 2007 16:18:49 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkQD9-0005TY-Ly for grub-devel@gnu.org; Tue, 23 Oct 2007 16:18:47 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IkQD9-0004ZI-Do for grub-devel@gnu.org; Tue, 23 Oct 2007 16:18:47 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IkQD7-0007AX-TB for grub-devel@gnu.org; Tue, 23 Oct 2007 22:18:46 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IkQD2-0007nL-4z for grub-devel@gnu.org; Tue, 23 Oct 2007 22:18:40 +0200 Date: Tue, 23 Oct 2007 22:18:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071023201840.GB29047@thorin> References: <471E4628.9030706@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <471E4628.9030706@t-online.de> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2007 20:18:50 -0000 On Tue, Oct 23, 2007 at 09:06:16PM +0200, Christian Franke wrote: > This patch fixes the broken evaluation of the E801 EISA memory map. The > shift was too much, the high word is already shifted :-) The bug was > hidden until the E820 memory map evaluation was broken due to the struct > packing issue fixed in my last patch. > > The extra handling of "0x3C00" case is IMO not necessary. Regions are > merged a few lines later. > > During testing, I added a primitive memory to detect such problems > early. It was difficult to find why grub crashes during module load. Is this related to Cygwin? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)