From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]) by pentafluge.infradead.org with esmtps (Exim 4.63 #1 (Red Hat Linux)) id 1IkZp9-0007Ys-Pg for kexec@lists.infradead.org; Wed, 24 Oct 2007 07:34:44 +0100 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l9O6WwF8020569 for ; Wed, 24 Oct 2007 02:32:58 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9O6VQcm091632 for ; Wed, 24 Oct 2007 02:31:26 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9O6VPsD009461 for ; Wed, 24 Oct 2007 02:31:25 -0400 Date: Wed, 24 Oct 2007 12:01:41 +0530 From: Vivek Goyal Subject: Re: [PATCH 2/3] x86: add safe_smp_processor_id for x86_64 Message-ID: <20071024063141.GB4622@in.ibm.com> References: <47195763.1090803@ct.jp.nec.com> <47195876.7080208@ct.jp.nec.com> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <47195876.7080208@ct.jp.nec.com> Reply-To: vgoyal@in.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces@lists.infradead.org To: Hiroshi Shimamoto Cc: hbabu@us.ibm.com, tglx@linutronix.de, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Fernando Luis Vazquez Cao On Fri, Oct 19, 2007 at 06:23:02PM -0700, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Signed-off-by: Hiroshi Shimamoto > --- > include/asm-x86/smp_64.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/asm-x86/smp_64.h b/include/asm-x86/smp_64.h > index 6f0e027..ab612b0 100644 > --- a/include/asm-x86/smp_64.h > +++ b/include/asm-x86/smp_64.h > @@ -76,6 +76,8 @@ extern unsigned __cpuinitdata disabled_cpus; > > #endif /* CONFIG_SMP */ > > +#define safe_smp_processor_id() smp_processor_id() > + Can you please implement a patch for safe_smp_processor_id() instead of using smp_processor_id(). safe_smp_processor_id() was introduced to make sure that we are not dependent on the stack of threads after kernel has crashed instead read the apic id and convert it to cpu id with other data structures. This helped in stack overflow case. Hardcoding it to smp_processor_id() will give the false impression. Thanks Vivek _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476AbXJXGbk (ORCPT ); Wed, 24 Oct 2007 02:31:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753498AbXJXGbd (ORCPT ); Wed, 24 Oct 2007 02:31:33 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:54910 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139AbXJXGbc (ORCPT ); Wed, 24 Oct 2007 02:31:32 -0400 Date: Wed, 24 Oct 2007 12:01:41 +0530 From: Vivek Goyal To: Hiroshi Shimamoto Cc: hbabu@us.ibm.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Fernando Luis Vazquez Cao Subject: Re: [PATCH 2/3] x86: add safe_smp_processor_id for x86_64 Message-ID: <20071024063141.GB4622@in.ibm.com> Reply-To: vgoyal@in.ibm.com References: <47195763.1090803@ct.jp.nec.com> <47195876.7080208@ct.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47195876.7080208@ct.jp.nec.com> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 19, 2007 at 06:23:02PM -0700, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Signed-off-by: Hiroshi Shimamoto > --- > include/asm-x86/smp_64.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/asm-x86/smp_64.h b/include/asm-x86/smp_64.h > index 6f0e027..ab612b0 100644 > --- a/include/asm-x86/smp_64.h > +++ b/include/asm-x86/smp_64.h > @@ -76,6 +76,8 @@ extern unsigned __cpuinitdata disabled_cpus; > > #endif /* CONFIG_SMP */ > > +#define safe_smp_processor_id() smp_processor_id() > + Can you please implement a patch for safe_smp_processor_id() instead of using smp_processor_id(). safe_smp_processor_id() was introduced to make sure that we are not dependent on the stack of threads after kernel has crashed instead read the apic id and convert it to cpu id with other data structures. This helped in stack overflow case. Hardcoding it to smp_processor_id() will give the false impression. Thanks Vivek