From: Ingo Molnar <mingo@elte.hu>
To: Chris Holvenstot <cholvenstot@comcast.net>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Build Failure with 2.6.24-rc1
Date: Wed, 24 Oct 2007 12:30:12 +0200 [thread overview]
Message-ID: <20071024103012.GA16917@elte.hu> (raw)
In-Reply-To: <1193221627.5685.2.camel@localhost>
* Chris Holvenstot <cholvenstot@comcast.net> wrote:
> When attempting to build the 2.6.24-rc1 kernel:
>
> arch/x86/kernel/built-in.o: In function `smp_send_nmi_allbutself':
> /build/linux/arch/x86/kernel/crash.c:85: undefined reference to
> `genapic'
> make: *** [.tmp_vmlinux1] Error 1
the patch below should fix this.
Ingo
------------------>
Subject: x86: fix CONFIG_KEXEC build breakage
From: Mike Galbraith <efault@gmx.de>
X86_32 build fix to commit 62a31a03b3d2a9d20e7a073e2cd9b27bfb7d6a3f
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/crash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-x86.q/arch/x86/kernel/crash.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/crash.c
+++ linux-x86.q/arch/x86/kernel/crash.c
@@ -25,7 +25,7 @@
#include <linux/kdebug.h>
#include <asm/smp.h>
-#ifdef X86_32
+#ifdef CONFIG_X86_32
#include <mach_ipi.h>
#else
#include <asm/mach_apic.h>
@@ -41,7 +41,7 @@ static int crash_nmi_callback(struct not
unsigned long val, void *data)
{
struct pt_regs *regs;
-#ifdef X86_32
+#ifdef CONFIG_X86_32
struct pt_regs fixed_regs;
#endif
int cpu;
@@ -60,7 +60,7 @@ static int crash_nmi_callback(struct not
return NOTIFY_STOP;
local_irq_disable();
-#ifdef X86_32
+#ifdef CONFIG_X86_32
if (!user_mode_vm(regs)) {
crash_fixup_ss_esp(&fixed_regs, regs);
regs = &fixed_regs;
next prev parent reply other threads:[~2007-10-24 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 10:27 Build Failure with 2.6.24-rc1 Chris Holvenstot
2007-10-24 10:30 ` Ingo Molnar [this message]
2007-10-24 10:47 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024103012.GA16917@elte.hu \
--to=mingo@elte.hu \
--cc=cholvenstot@comcast.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.