From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Dale Farnsworth" Date: Wed, 24 Oct 2007 05:08:04 -0700 To: Valentine Barshak Subject: Re: [PATCH] PowerPC 440EPx Sequoia USB OHCI DTS entry Message-ID: <20071024120804.GA1180@xyzzy.farnsworth.org> References: <20071008142658.GA15197@ru.mvista.com> <20071023214000.424.qmail@farnsworth.org> <471F2A32.8030202@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <471F2A32.8030202@ru.mvista.com> Cc: Linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 24, 2007 at 03:19:14PM +0400, Valentine Barshak wrote: > Dale Farnsworth wrote: > >Valentine wrote: > >>Actually I also don't see much reason for the > >>USB_OHCI_HCD_PPC_OF_BE/USB_OHCI_HCD_PPC_OF_LE stuff. > >>Is this really needed? > > > >I think so. The SOC host controllers are BE and the PCI > >host controllers are LE. Or, do you have an alternative > >method of handling both types? > > Yes, PCI controllers are LE, but do we really need user-selectable > USB_OHCI_HCD_PPC_OF_LE option, since USB_OHCI_LITTLE_ENDIAN is selected > by default for USB_OHCI_HCD_PCI? > The USB_OHCI_HCD_PPC_OF_LE/BE stuff is related to PPC OF glue only. > I think it's useless. We should always enable > USB_OHCI_BIG_ENDIAN_DESC and USB_OHCI_BIG_ENDIAN_MMIO for PPC OF > and the real LE/BE implementation should be selected by the > corresponding properties in the device tree. I agree that they don't need to be user selectable. It is far preferable to deduce their values from existing information, if possible. -Dale