Hi, I'm getting spurious wakes and crashes when using xenbus_wake_for_value. It looks to me like the attached patch is needed because else the wait element is kept in the watch queue (just like in the wait_event() macro, and it does fix my issues). Samuel