From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkiF5-0000uw-0m for qemu-devel@nongnu.org; Wed, 24 Oct 2007 11:33:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkiF4-0000u8-2J for qemu-devel@nongnu.org; Wed, 24 Oct 2007 11:33:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkiF3-0000tj-S2 for qemu-devel@nongnu.org; Wed, 24 Oct 2007 11:33:57 -0400 Received: from relay01.mx.bawue.net ([193.7.176.67]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IkiF3-0007tB-B2 for qemu-devel@nongnu.org; Wed, 24 Oct 2007 11:33:57 -0400 Date: Wed, 24 Oct 2007 16:33:49 +0100 From: Thiemo Seufer Subject: Re: [Qemu-devel] qemu-2007-10-24 build error Message-ID: <20071024153349.GB6666@networkno.de> References: <20071024003602.0000F11F01F20261@mail6.dreamwiz.com> <1193222005.16781.225.camel@rapid> <20071024123619.GG13076@edgar.underground.se.axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071024123619.GG13076@edgar.underground.se.axis.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: "J. Mayer" , qemu-devel@nongnu.org, hys545@dreamwiz.com Edgar E. Iglesias wrote: > On Wed, Oct 24, 2007 at 12:33:24PM +0200, J. Mayer wrote: > > On Wed, 2007-10-24 at 09:36 +0900, Hwang YunSong(?????????) wrote: > > > > > > gcc32 -g -o qemu-system-cris vl.o osdep.o readline.o monitor.o pci.o > > > console.o loader.o isa_mmio.o cutils.o block.o block-raw.o block-cow.o > > > block-qcow.o aes.o block-vmdk.o block-cloop.o block-dmg.o > > > block-bochs.o block-vpc.o block-vvfat.o block-qcow2.o > > > block-parallels.o irq.o i2c.o smbus.o scsi-disk.o cdrom.o lsi53c895a.o > > > usb.o usb-hub.o usb-linux.o usb-hid.o usb-ohci.o usb-msd.o usb-wacom.o > > > eeprom93xx.o eepro100.o ne2000.o pcnet.o rtl8139.o etraxfs.o ptimer.o > > > etraxfs_timer.o etraxfs_ser.o gdbstub.o sdl.o x_keymap.o vnc.o d3des.o > > > slirp/cksum.o slirp/if.o slirp/ip_icmp.o slirp/ip_input.o > > > slirp/ip_output.o slirp/slirp.o slirp/mbuf.o slirp/misc.o slirp/sbuf.o > > > slirp/socket.o slirp/tcp_input.o slirp/tcp_output.o slirp/tcp_subr.o > > > slirp/tcp_timer.o slirp/udp.o slirp/bootp.o slirp/debug.o slirp/tftp.o > > > libqemu.a -lm -lz -lgnutls -L/usr/lib -lSDL -lpthread -lrt -lutil > > > libqemu.a(helper.o): In function `do_interrupt': > > > /usr/src/Haansoft/BUILD/qemu/target-cris/helper.c:137: undefined > > > reference to `__builtin_clz' > > > libqemu.a(translate-op.o): In function `dyngen_code': > > > /home/hys545/qemu/cris-softmmu/op.h:1566: undefined reference to > > > `__builtin_clz' > > > libqemu.a(op.o): In function `op_lz_T0_T1': > > > /usr/src/Haansoft/BUILD/qemu/target-cris/op.c:1009: undefined > > > reference to `__builtin_clz' > > > collect2: ld returned 1 exit status > > > > It does not seem to be a good idea, imho, to use gcc builtins directly > > from micro-ops. But your compiler should implement __builtin_clz. As far > > Hi, > > I submitted a patch that at compile-time fallbacks to clz code without builtins. Do you see any additional issues with using the builtins? > > I think the speed-up with GCC ports implementing fast builtin variants of operations like clz would be significant enough to justify their use but if there is disagreement I'll send in a new patch removing the builtin_clz alltogether. If the builtin ends up calling into libgcc (this can happen depending on the host / host compiler), then the dynamic code generation breaks. It is safer not to force the compiler to use builtins. Thiemo