From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jeff Garzik <jeff@garzik.org>, Sam Ravnborg <sam@ravnborg.org>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [RFC] create instrumentation/ directory
Date: Wed, 24 Oct 2007 13:31:02 -0400 [thread overview]
Message-ID: <20071024173102.GA29958@Krystal> (raw)
In-Reply-To: <20071024091240.7978c2da.rdunlap@xenotime.net>
* Randy Dunlap (rdunlap@xenotime.net) wrote:
> On Wed, 24 Oct 2007 09:19:05 -0400 Jeff Garzik wrote:
>
> > Honestly, I don't care at all about building the code. If that's what
> > you want, great.
>
> Yes, that is wanted. They bitrot too easily -- not good.
>
> > My objection is more to adding a samples/ directory, which is contra to
> > past experience:
> >
> > A new net driver sample should go in drivers/net/ like the existing
> > skeleton files I already listed, not samples/net/. A top-level
>
> Can't disagree with that.
>
> > "samples/" seems like it exists only duplicate the rest of the tree
> > hierarchy.
>
> It seems odd to be building code in Documentation/, but I can live
> with that. It was primarily Christoph who was opposed to that.
> He suggested samples/ and I went along with it just to break the
> impasse (since no one else was making any comments on it at that
> time).
>
> Sam, would building code in Documentation/ cause problems for
> kbuild?
Since we already have the Instrumentation menu in
kernel/Kconfig.instrumentation and instrumentation code all over the
kernel tree:
arch/*/oprofile/*.c
kernel/kprobes.c
arch/*/kernel/kprobes.c
kernel/marker.c
kernel/profile.c
kernel/profile.S
kernel/lockdep.c
vm/vmstat.c
block/blktrace.c
We could move them to
instrumentation/
arch/*/instrumentation/
Therefore, we could also move the kprobes and marker samples under
instrumentation/samples/
My main concern is that 15 characters long directory name might be
inelegant (however, it only beats Documentation by 2).
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-10-24 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 9:52 [RFC/git patch] move samples/ to Documentation/markers/ Jeff Garzik
2007-10-24 10:10 ` Sam Ravnborg
2007-10-24 13:05 ` Mathieu Desnoyers
2007-10-24 13:19 ` Jeff Garzik
2007-10-24 16:12 ` Randy Dunlap
2007-10-24 16:17 ` Sam Ravnborg
2007-10-24 17:31 ` Mathieu Desnoyers [this message]
2007-10-24 17:48 ` [RFC] create instrumentation/ directory Randy Dunlap
2007-10-25 20:08 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024173102.GA29958@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=fche@redhat.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.