Re: [RFC] full suspend/resume support for i915 DRM driver

[Adrian Bunk <bunk@kernel.org>]

On Mon, Oct 22, 2007 at 09:15:43PM -0700, Jesse Barnes wrote:
> On Friday, October 19, 2007, Jesse Barnes wrote:
> > Dave can you take a look at the new flag and also see what you think
> > about supporting suspend/resume in the event X hasn't started yet?
> > There's some #if 0'd code to support that case, but I haven't tested
> > it.
> 
> Ok Dave, this one's been updated with support for suspend/resume with
> or without X running (iow I removed the requirement that X initialize
> the driver, which DRM drivers usually have).
> 
> Hope it looks alright, it could definitely use testing on more
> machines though...
> 
> Jesse
> 
> diff --git a/linux-core/Kconfig b/linux-core/Kconfig
> index 2d02c76..5e73fc7 100644
> --- a/linux-core/Kconfig
> +++ b/linux-core/Kconfig
> @@ -50,7 +50,7 @@ config DRM_I810
>  
>  choice
>  	prompt "Intel 830M, 845G, 852GM, 855GM, 865G"
> -	depends on DRM && AGP && AGP_INTEL
> +	depends on DRM && AGP && AGP_INTEL && !FB_INTEL
>  	optional
>...

This sounds like a bad regression.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed