All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dlstevens@us.ibm.com
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
	netdev-owner@vger.kernel.org
Subject: Re: [PATCH] NET: Mark snmp4_icmp_list[] as being unused
Date: Thu, 25 Oct 2007 18:40:32 -0700 (PDT)	[thread overview]
Message-ID: <20071025.184032.206866652.davem@davemloft.net> (raw)
In-Reply-To: <OF4EE0CEBB.1648619D-ON88257380.00077574-88257380.0007E67A@us.ibm.com>

From: David Stevens <dlstevens@us.ibm.com>
Date: Thu, 25 Oct 2007 18:27:22 -0700

> dhowells@redhat.com wrote on 10/25/2007 04:05:13 PM:
> 
> > David Stevens <dlstevens@us.ibm.com> wrote:
> > 
> > > What about just removing it, or do you think it's
> > > useful for documentation of the order? Either way,
> > 
> > I don't know whether it's intended to be used for something, perhaps a
> > debugging macro.  Perhaps it should be #if'd out instead.
> 
>         It was used for /proc/net/snmp header printing, but
> most of the items in it were moved to a different MIB (by me).
> The new values are printed in a backward-compatible way, but
> maintaining the old order means not using this header map.
>         So, long-winded way of saying I believe it should be
> removed, but I missed that when I made it obsolete. :-)

I've checked just such a change into my tree.

Thanks!

      reply	other threads:[~2007-10-26  1:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 13:36 [PATCH] NET: Mark snmp4_icmp_list[] as being unused David Howells
2007-10-25 22:10 ` David Stevens
2007-10-25 23:05   ` David Howells
2007-10-26  1:27     ` David Stevens
2007-10-26  1:40       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071025.184032.206866652.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev-owner@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.