From: Matthew Wilcox <matthew@wil.cx>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Jean Delvare <khali@linux-fr.org>,
linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] scsi/sym53c8xx: Fix a warning in sym_eh_handler
Date: Thu, 25 Oct 2007 05:19:06 -0600 [thread overview]
Message-ID: <20071025111905.GK27248@parisc-linux.org> (raw)
In-Reply-To: <472063CE.6040409@panasas.com>
On Thu, Oct 25, 2007 at 11:37:18AM +0200, Boaz Harrosh wrote:
> On Wed, Oct 24 2007 at 11:59 +0200, Jean Delvare <khali@linux-fr.org> wrote:
> > - struct completion *io_reset;
> > - int finished_reset = 0;
> > + struct completion *io_reset = NULL;
> > + int finished_reset;
[...]
> > - if (!finished_reset)
> > + if (io_reset) {
> I think you should use uninitialized_var and not brute = NULL;
Look at the patch more carefully ... uninitialized_var would be
inappropriate.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2007-10-25 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 9:59 [PATCH] scsi/sym53c8xx: Fix a warning in sym_eh_handler Jean Delvare
2007-10-24 11:25 ` Matthew Wilcox
2007-10-24 12:46 ` Jean Delvare
2007-10-25 9:37 ` Boaz Harrosh
2007-10-25 11:19 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025111905.GK27248@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=bharrosh@panasas.com \
--cc=khali@linux-fr.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.