On Thursday 25 October 2007 12:43, Denys Vlasenko wrote:
> Hi Hervert,
> 
> Please review and maybe propagate upstream following patches.
> 
> camellia1.diff:
>     Move code blocks around so that related pieces are closer together:
>     e.g. CAMELLIA_ROUNDSM macro does not need to be separated
>     from the rest of the code by huge array of constants.
> 
>     Remove unused macros (COPY4WORD, SWAP4WORD, XOR4WORD[2])
> 
>     Drop SUBL(), SUBR() macros which only obscure things.
>     Same for CAMELLIA_SP1110() macro and KEY_TABLE_TYPE typedef.
> 
>     Remove useless comments:
>     /* encryption */ -- well it's obvious enough already!
>     void camellia_encrypt128(...)
> 
>     Combine swap with copying at the beginning/end of encrypt/decrypt.

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
--
vda