From: Andrew Morton <akpm@linux-foundation.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: mm-commits@vger.kernel.org, lenb@kernel.org,
mhoffman@lightlink.com, trenn@suse.de
Subject: Re: + provide-acpi_check_mem_region-checkpatch-fixes.patch added to -mm tree
Date: Thu, 25 Oct 2007 13:16:46 -0700 [thread overview]
Message-ID: <20071025131646.75f01aa4.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071025154104.33b7b8e1@hyperion.delvare>
On Thu, 25 Oct 2007 15:41:04 +0200
Jean Delvare <khali@linux-fr.org> wrote:
> Hi Andrew,
>
> On Wed, 24 Oct 2007 20:51:33 -0700, akpm@linux-foundation.org wrote:
> >
> > The patch titled
> > provide-acpi_check_mem_region-checkpatch-fixes
> > has been added to the -mm tree. Its filename is
> > provide-acpi_check_mem_region-checkpatch-fixes.patch
> >
> > *** Remember to use Documentation/SubmitChecklist when testing your code ***
> >
> > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> > out what to do about this
> >
> > ------------------------------------------------------
> > Subject: provide-acpi_check_mem_region-checkpatch-fixes
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > WARNING: printk() should include KERN_ facility level
> > #133: FILE: drivers/acpi/osl.c:1133:
> > + printk("%sACPI: %s resource %s [0x%llx-0x%llx]"
> >
> > total: 0 errors, 1 warnings, 224 lines checked
> > Your patch has style problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> >
> > Please run checkpatch prior to sending patches
>
> Except that checkpatch is wrong in this case, the original patch was
> correct and your add-on broke it. The log level is %s because it
> depends on the value of acpi_enforce_resources.
>
> I admit it's a bit tricky and I'm not surprised checkpatch got
> confused. It's probably rare enough that it's not worth fixing the
> script.
OK. We now have KERN_CONT, which is the empty string. It could have been
used here as a way of keeping checkpatch happy and to tell readers "yes,
this printk's faciliy level has been thought about".
KERN_CONT is also useful for things like ata_dev_printk() which _require_ a
facility level.
prev parent reply other threads:[~2007-10-25 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 3:51 + provide-acpi_check_mem_region-checkpatch-fixes.patch added to -mm tree akpm
[not found] ` <20071025154104.33b7b8e1@hyperion.delvare>
2007-10-25 20:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025131646.75f01aa4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhoffman@lightlink.com \
--cc=mm-commits@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.