From: Ralf Baechle <ralf@linux-mips.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-mips@linux-mips.org
Subject: [IDE] Fix build bug
Date: Thu, 25 Oct 2007 14:53:34 +0100 [thread overview]
Message-ID: <20071025135334.GA23272@linux-mips.org> (raw)
CC drivers/ide/pci/generic.o
drivers/ide/pci/generic.c:52: error: __setup_str_ide_generic_all_on causes a
+section type conflict
This sort of build error is becoming a regular issue. Either all or non
of the elements that go into a particular section of a compilation unit
need to be const. Or an error may result such as in this case if
CONFIG_HOTPLUG is unset.
Maybe worth a check in checkpatch.pl - but certainly gcc's interolerance
is also being less than helpful here.
---
drivers/ide/pci/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c
index f44d708..0047684 100644
--- a/drivers/ide/pci/generic.c
+++ b/drivers/ide/pci/generic.c
@@ -67,7 +67,7 @@ MODULE_PARM_DESC(all_generic_ide, "IDE generic will claim all unknown PCI IDE st
.udma_mask = ATA_UDMA6, \
}
-static const struct ide_port_info generic_chipsets[] __devinitdata = {
+static struct ide_port_info generic_chipsets[] __devinitdata = {
/* 0 */ DECLARE_GENERIC_PCI_DEV("Unknown", 0),
{ /* 1 */
next reply other threads:[~2007-10-25 13:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 13:53 Ralf Baechle [this message]
2007-10-25 14:13 ` [IDE] Fix build bug Sam Ravnborg
2007-10-25 14:13 ` Ralf Baechle
2007-10-25 14:47 ` Maciej W. Rozycki
2007-10-25 16:05 ` Ralf Baechle
2007-10-25 17:12 ` Maciej W. Rozycki
2007-10-25 21:52 ` Bartlomiej Zolnierkiewicz
2007-10-25 21:41 ` Bartlomiej Zolnierkiewicz
2007-10-30 11:34 ` Denys Vlasenko
2007-10-30 12:41 ` Ralf Baechle
2007-10-30 20:30 ` Bartlomiej Zolnierkiewicz
2007-11-01 18:43 ` Denys Vlasenko
2007-11-02 12:34 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025135334.GA23272@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.