All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 0/6] kill i386 and x86_64 directories
Date: Thu, 25 Oct 2007 22:14:37 +0200	[thread overview]
Message-ID: <20071025201437.GA14671@uranus.ravnborg.org> (raw)
In-Reply-To: <20071025195644.GA14501@uranus.ravnborg.org>

On Thu, Oct 25, 2007 at 09:56:44PM +0200, Sam Ravnborg wrote:
> This series kill the old i386 and x86_64 directories.
> The relevant files are moved and adapted and
> Kconfig.debug was consolidated (thanks to Randy).
> 
> I had to modify both the top-lvel Makefile and the kconfig
> Makefile to accomplish this. It was done in such a way that
> it is trivial for other archs to use the same mechanism
> should they have the need.
> 
> To solve the defconfig issue (i386 and x86_64 cannot share one)
> the arch/x86/configs/ directory were introduced. This has
> been used by other archs for some time now but x86 had not had
> the need until now.
> 
> The Kconfig files could be consolidated much more - I only
> did the minimal changes to make it work in the new place.
> 
> Total diffstat (in git format):
> 
>  Makefile                                           |    7 ++-
>  arch/i386/.gitignore                               |    1 -
>  arch/{i386 => x86}/Kconfig.cpu                     |    0 
>  arch/{i386 => x86}/Kconfig.debug                   |   51 +++++++++++++---
>  arch/{i386/Kconfig => x86/Kconfig.i386}            |    4 +-
>  arch/{x86_64/Kconfig => x86/Kconfig.x86_64}        |    6 +--
>  arch/x86/Makefile                                  |   16 +++++
>  arch/{i386/Makefile => x86/Makefile_32}            |    7 +--
>  arch/{i386/Makefile.cpu => x86/Makefile_32.cpu}    |    0 
>  arch/{x86_64/Makefile => x86/Makefile_64}          |    5 +-
>  .../{i386/defconfig => x86/configs/i386_defconfig} |    0 
>  .../defconfig => x86/configs/x86_64_defconfig}     |    0 
>  arch/x86_64/.gitignore                             |    1 -
>  arch/x86_64/Kconfig.debug                          |   61 --------------------
>  scripts/kconfig/Makefile                           |   35 +++++++-----
>  15 files changed, 89 insertions(+), 105 deletions(-)
> 

By the way I consider this -rc1 material.
Because:
1) It sort of finishes the initial merge
2) Any breakage should be easy to trigger (build breakage) and easy to fix.

It is 1) that make me say this is -rc1 materail,
 and 2) that say that this is an acceptable 'breaking the rules' patch serie.

	Sam

  parent reply	other threads:[~2007-10-25 20:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 19:56 [PATCH 0/6] kill i386 and x86_64 directories Sam Ravnborg
2007-10-25 20:03 ` [PATCH 1/6] x86: move i386 and x86_64 Makefiles to arch/x86 Sam Ravnborg
2007-10-25 20:03 ` [PATCH 2/6] x86: move defconfig files for i386 and x86_64 to x86 Sam Ravnborg
2007-10-25 20:04 ` [PATCH 3/6] x86: unification of i386 and x86_64 Kconfig.debug Sam Ravnborg
2007-10-25 23:30   ` Yinghai Lu
2007-10-25 23:35     ` Randy Dunlap
2007-10-25 23:52       ` H. Peter Anvin
2007-10-26  1:55         ` Yinghai Lu
2007-10-26  4:29     ` Sam Ravnborg
2007-10-25 20:05 ` [PATCH 4/6] kconfig: small code refactoring in kconfig Makefile Sam Ravnborg
2007-10-25 20:05 ` [PATCH 5/6] x86: move i386 and x86_64 Kconfig files to x86 directory Sam Ravnborg
2007-10-26  1:53   ` Yinghai Lu
2007-10-26  2:46     ` Randy Dunlap
2007-10-26  5:51       ` Yinghai Lu
2007-10-26  6:02         ` Randy Dunlap
2007-10-26  6:14         ` Sam Ravnborg
2007-10-26  6:39           ` Yinghai Lu
2007-10-26  6:58             ` Sam Ravnborg
2007-10-25 20:06 ` [PATCH 6/6] x86: kill the old i386 and x86_64 directories Sam Ravnborg
2007-10-25 20:14 ` Sam Ravnborg [this message]
2007-10-25 20:19   ` [PATCH 0/6] kill " Kay Sievers
2007-10-25 20:36     ` Sam Ravnborg
2007-10-25 20:17 ` Thomas Gleixner
2007-10-25 21:12   ` [GIT PULL] " Sam Ravnborg
2007-10-26  6:23   ` [PATCH 0/6] " Sam Ravnborg
2007-10-26 12:01     ` Alan Cox
2007-10-26 14:39     ` Arjan van de Ven
     [not found] <9ih2i-qd-15@gated-at.bofh.it>
     [not found] ` <9ihlw-193-21@gated-at.bofh.it>
2007-10-26  3:30   ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071025201437.GA14671@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=hpa@zytor.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.