All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Paul Menage <menage@google.com>
Cc: Paul Jackson <pj@sgi.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/cgroup.c: remove dead code
Date: Fri, 26 Oct 2007 03:19:50 +0200	[thread overview]
Message-ID: <20071026011950.GA30533@stusta.de> (raw)
In-Reply-To: <6599ad830710251810r6bb1e390nf3612031af8b6767@mail.gmail.com>

On Thu, Oct 25, 2007 at 06:10:24PM -0700, Paul Menage wrote:
> On 10/24/07, Paul Jackson <pj@sgi.com> wrote:
> > Paul M wrote:
> > > I think I'd rather not make this change - if we later changed the size
> > > of release_agent_path[] this could silently fail. Can we get around
> > > the coverity checker somehow?
> >
> > Perhaps we can simplify this check then, to:
> >
> >   BUG_ON(sizeof(cgrp->root->release_agent_path) < PATH_MAX));
> >
> > Less runtime code.
> 
> Sounds reasonable to me. Is there any kind of compile-time assert
> macro in the kernel?

BUILD_BUG_ON()

> Paul

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-10-26  1:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 16:25 [2.6 patch] kernel/cgroup.c: remove dead code Adrian Bunk
2007-10-24 16:30 ` Paul Menage
2007-10-24 17:07   ` Adrian Bunk
2007-10-24 17:13     ` Paul Menage
2007-10-24 17:34   ` Paul Jackson
2007-10-26  1:10     ` Paul Menage
2007-10-26  1:19       ` Adrian Bunk [this message]
2007-10-26  1:24       ` Paul Jackson
2007-10-26  1:26         ` Paul Menage
2007-10-26  1:37           ` Paul Jackson
2007-10-26  1:30         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071026011950.GA30533@stusta.de \
    --to=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.