All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] raid6: generate raid6tables.c with proper style
Date: Fri, 26 Oct 2007 10:17:52 +0200	[thread overview]
Message-ID: <20071026081752.GA1232@elte.hu> (raw)

Subject: raid6: generate raid6tables.c with proper style
From: Ingo Molnar <mingo@elte.hu>

nitpicking from the coding style police: generate a raid6tables.c that 
does not show up in my editor all red ;-)

this also improves the code quality metric of drivers/md/ by
a factor of 10:

                             errors   lines of code   errors/KLOC
 drivers/md/  [old]            9349           45543         205.2
 drivers/md/  [new]            1062           45551          23.3

while humans are not likely to read that file, lets just do this to make 
life easier for automated quality checking ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/md/mktables.c |   16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

Index: linux/drivers/md/mktables.c
===================================================================
--- linux.orig/drivers/md/mktables.c
+++ linux/drivers/md/mktables.c
@@ -69,7 +69,9 @@ int main(int argc, char *argv[])
     for ( j = 0 ; j < 256 ; j += 8 ) {
       printf("\t\t");
       for ( k = 0 ; k < 8 ; k++ ) {
-	printf("0x%02x, ", gfmul(i,j+k));
+        if (k)
+	  printf(" ");
+	printf("0x%02x,", gfmul(i,j+k));
       }
       printf("\n");
     }
@@ -86,7 +88,9 @@ int main(int argc, char *argv[])
     printf("\t");
     for ( j = 0 ; j < 8 ; j++ ) {
       exptbl[i+j] = v;
-      printf("0x%02x, ", v);
+      if (j)
+	      printf(" ");
+      printf("0x%02x,", v);
       v = gfmul(v,2);
       if ( v == 1 ) v = 0;	/* For entry 255, not a real entry */
     }
@@ -102,7 +106,9 @@ int main(int argc, char *argv[])
     printf("\t");
     for ( j = 0 ; j < 8 ; j++ ) {
       invtbl[i+j] = v = gfpow(i+j,254);
-      printf("0x%02x, ", v);
+      if (j)
+	      printf(" ");
+      printf("0x%02x,", v);
     }
     printf("\n");
   }
@@ -115,7 +121,9 @@ int main(int argc, char *argv[])
   for ( i = 0 ; i < 256 ; i += 8 ) {
     printf("\t");
     for ( j = 0 ; j < 8 ; j++ ) {
-      printf("0x%02x, ", invtbl[exptbl[i+j]^1]);
+      if (j)
+	      printf(" ");
+      printf("0x%02x,", invtbl[exptbl[i+j]^1]);
     }
     printf("\n");
   }

             reply	other threads:[~2007-10-26  8:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26  8:17 Ingo Molnar [this message]
2007-10-26 11:26 ` [patch] raid6: generate raid6tables.c with proper style Simon Holm Thøgersen
2007-10-26 15:22   ` Ingo Molnar
2007-10-26 17:01     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071026081752.GA1232@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.