diff for duplicates of <20071026103647.78f44826@hyperion.delvare> diff --git a/a/1.txt b/N1/1.txt index 3260cd1..baf5b75 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -31,8 +31,8 @@ On Thu, 25 Oct 2007 14:48:14 +0300, Riku Voipio wrote: > int val = simple_strtoul(buf, NULL, 10); > u8 conf = 0; > -> - if (val != 0 || val != 1 || data->kind = f75373) -> + if (!(val = 0 || val = 1)) +> - if (val != 0 || val != 1 || data->kind == f75373) +> + if (!(val == 0 || val == 1)) > return -EINVAL; > > mutex_lock(&data->update_lock); @@ -56,7 +56,7 @@ On Thu, 25 Oct 2007 14:48:14 +0300, Riku Voipio wrote: > if ((err = sysfs_create_group(&client->dev.kobj, &f75375_group))) > goto exit_detach; > -> + if (kind = f75375) { +> + if (kind == f75375) { > + err = sysfs_chmod_file(&client->dev.kobj, > + &sensor_dev_attr_pwm1_mode.dev_attr.attr, > + S_IRUGO | S_IWUSR); @@ -82,8 +82,3 @@ the -rc1 merge)? Thanks. -- Jean Delvare - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 01321fd..0eba6ad 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,7 +7,7 @@ "ref\020071025114814.GA2452@kos.to\0" "From\0Jean Delvare <khali@linux-fr.org>\0" "Subject\0Re: [lm-sensors] hwmon/f75375s.c: buggy if()\0" - "Date\0Fri, 26 Oct 2007 08:36:47 +0000\0" + "Date\0Fri, 26 Oct 2007 10:36:47 +0200\0" "To\0Riku Voipio <riku.voipio@iki.fi>\0" "Cc\0Mark M. Hoffman <mhoffman@lightlink.com>" Adrian Bunk <bunk@kernel.org> @@ -48,8 +48,8 @@ "> \tint val = simple_strtoul(buf, NULL, 10);\n" "> \tu8 conf = 0;\n" "> \n" - "> -\tif (val != 0 || val != 1 || data->kind = f75373)\n" - "> +\tif (!(val = 0 || val = 1))\n" + "> -\tif (val != 0 || val != 1 || data->kind == f75373)\n" + "> +\tif (!(val == 0 || val == 1))\n" "> \t\treturn -EINVAL;\n" "> \n" "> \tmutex_lock(&data->update_lock);\n" @@ -73,7 +73,7 @@ "> \tif ((err = sysfs_create_group(&client->dev.kobj, &f75375_group)))\n" "> \t\tgoto exit_detach;\n" "> \n" - "> +\tif (kind = f75375) {\n" + "> +\tif (kind == f75375) {\n" "> +\t\terr = sysfs_chmod_file(&client->dev.kobj,\n" "> +\t\t\t&sensor_dev_attr_pwm1_mode.dev_attr.attr,\n" "> +\t\t\tS_IRUGO | S_IWUSR);\n" @@ -98,11 +98,6 @@ "the -rc1 merge)? Thanks.\n" "\n" "-- \n" - "Jean Delvare\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Jean Delvare -162ae5e68b1a72eb6115feb27a16de6633e32ebfa4ebb46a7c2fb850b86b7472 +e179d068ac935c8e9728999eff9e1b3b6ff7fc65385d4f7a78b60d2bb7faa2bf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.