From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: jens.axboe@oracle.com
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, linux-s390@vger.kernel.org
Subject: S390 change in sg_set_page() cause build failure
Date: Fri, 26 Oct 2007 16:49:45 +0530 [thread overview]
Message-ID: <20071026111945.GB21274@linux.vnet.ibm.com> (raw)
Hi Jens,
The change in the sg_set_page() for the S390, cause the build failure
drivers/s390/scsi/zfcp_aux.c: In function `zfcp_sg_list_alloc':
drivers/s390/scsi/zfcp_aux.c:572: error: too many arguments to function `zfcp_address_to_sg'
drivers/s390/scsi/zfcp_aux.c: In function `zfcp_gid_pn_buffers_alloc':
drivers/s390/scsi/zfcp_aux.c:1524: error: too many arguments to function `zfcp_address_to_sg'
drivers/s390/scsi/zfcp_aux.c:1525: error: too many arguments to function `zfcp_address_to_sg'
make[2]: *** [drivers/s390/scsi/zfcp_aux.o] Error 1
make[1]: *** [drivers/s390/scsi] Error 2
make: *** [drivers/s390] Error 2
The commit 642f149031d70415d9318b919d50b71e4724adbd causes this build
failure, in the drivers/s390/scsi/zfcp_def.h include file, the function
zfcp_address_to_sg the len of the scatterlist missing.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
index 0754542..acf2d22 100644
--- a/drivers/s390/scsi/zfcp_def.h
+++ b/drivers/s390/scsi/zfcp_def.h
@@ -70,9 +70,11 @@ zfcp_sg_to_address(struct scatterlist *list)
* zfcp_address_to_sg - set up struct scatterlist from kernel address
* @address: kernel address
* @list: struct scatterlist
+ * @list_size: size of the list - used for compatibility
*/
static inline void
-zfcp_address_to_sg(void *address, struct scatterlist *list)
+zfcp_address_to_sg(void *address, struct scatterlist *list,
+ unsigned int list_size)
{
sg_set_buf(list, address, 0);
}
--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM,ISTL.
next reply other threads:[~2007-10-26 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 11:19 Kamalesh Babulal [this message]
2007-10-26 11:54 ` S390 change in sg_set_page() cause build failure Jens Axboe
2007-10-26 14:35 ` Kamalesh Babulal
2007-10-29 11:22 ` [PATCH-RESEND] " Kamalesh Babulal
2007-10-29 11:26 ` Jens Axboe
2007-10-29 11:33 ` Kamalesh Babulal
2007-10-29 11:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026111945.GB21274@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.