From: Jens Axboe <jens.axboe@oracle.com>
To: Anton Blanchard <anton@samba.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Initialise scatter/gather list in ata_sg_setup
Date: Fri, 26 Oct 2007 13:58:59 +0200 [thread overview]
Message-ID: <20071026115859.GJ5155@kernel.dk> (raw)
In-Reply-To: <20071025193226.GA20459@kryten>
On Thu, Oct 25 2007, Anton Blanchard wrote:
>
> (Sorry the subject was incorrect)...
>
> After turning on DEBUG_SG I hit a fail:
>
> kernel BUG at include/linux/scatterlist.h:50!
>
> ata_qc_issue
> ata_scsi_translate
> ipr_queuecommand
> scsi_dispatch_cmd
> scsi_request_fn
> elv_insert
> blk_execute_rq_nowait
> blk_execute_rq
> sg_io
> scsi_cmd_ioctl
> cdrom_ioctl
> sr_block_ioctl
> blkdev_driver_ioctl
> blkdev_ioctl
> block_ioctl
> do_ioctl
> vfs_ioctl
> sys_ioctl
> sg_ioctl_trans
>
> It looks like ata_sg_setup is working on an uninitialised sg table. Call
> sg_init_table to initialise it before use.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> Jens this is against your sg branch. This fixes the fail but Id
> appreciate a confirmation that it's the right fix :)
The patch looks OK, you could also get away with just doing that
sg_init_table() on qc init/alloc.
--
Jens Axboe
prev parent reply other threads:[~2007-10-26 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 19:29 [PATCH] Initialise scatter/gather list in sg driver Anton Blanchard
2007-10-25 19:32 ` [PATCH] Initialise scatter/gather list in ata_sg_setup Anton Blanchard
2007-10-26 11:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026115859.GJ5155@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.