From mboxrd@z Thu Jan 1 00:00:00 1970 From: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Subject: Re: Q: How complete is the pid namespace in mainline Date: Fri, 26 Oct 2007 14:29:59 -0700 Message-ID: <20071026212959.GA15511@us.ibm.com> References: <20071026171718.GB11942@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Linux Containers , Cedric Le Goater , Pavel Emelyanov List-Id: containers.vger.kernel.org Eric W. Biederman [ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org] wrote: | sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org writes: | > | > Dave had suggested we print a warning the first time a container-init forks() | > without a handler for a fatal signal. I was planning on adding that as | > patch 4 of the signal patch set and get some feedback. | | Yes. How to cleanly handle signalling of container init is | a tricky one. It does sound like you have made a reasonable start | there. | | Suka it is a lot more then that. How much more I'm not certain | of. I suspect the only way to find the rest of the cases is | just go through the code with a fine tooth come and read and look. I agree. I did not mean to ignore the kthread conversions and was only referring to the core pid namespace clone stuff. | | So far doing that it has not at all hard for me to find either | bugs or places where the implementation can be improved. | | Currently we have little things like kill(-1,...) signalling the | wrong set of processes, and a couple of proc bugs. I just realized the fix for this is in the signal patchset I was referring to. https://lists.linux-foundation.org/pipermail/containers/2007-August/006987.html I notice that you have sent a patch for the kill -1. The proc_mnt bug Linus found seems to have slipped through when merging Pavel's and my patches.